Re: [PATCH 40/68] kern/syscall_subr.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
On 29.11.2013 23:46:57, Ivan Shmakov wrote: > Shouldn’t it be declared as ‘extern’ just as well? (And the > argument names are unnecessary, BTW.) Also, it may make sense > to “pair” it with thread_depress_timeout (), like: It's used only locally, so I figured extern is not need

Re: [PATCH 40/68] kern/syscall_subr.c: remove forward declaration

2013-11-29 Thread Ivan Shmakov
> Marin Ramesa writes: […] > --- a/kern/syscall_subr.h > +++ b/kern/syscall_subr.h > @@ -37,5 +37,6 @@ extern int thread_switch(mach_port_t, int, > mach_msg_timeout_t); > extern void thread_depress_timeout(thread_t); > extern kern_return_t thread_depress_abort(thread_t); > extern

[PATCH 40/68] kern/syscall_subr.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* kern/syscall_subr.c (thread_depress_priority): Remove forward declaration. * kern/syscall_subr.h (thread_depress_priority): Add prototype. --- kern/syscall_subr.c | 3 --- kern/syscall_subr.h | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/kern/syscall_subr.c b/kern/syscall