Re: [PATCH 4/4] utils/rpctrace: escape non-printable characters in strings

2013-12-15 Thread Samuel Thibault
Justus Winter, le Fri 13 Dec 2013 13:03:07 +0100, a écrit : > * utils/rpctrace.c (escape_sequences): New char array mapping > characters to their escape sequence. > (print_data): Escape non-printable characters when printing strings. Ack on the principle for a fixed patch :) > --- > utils/rpctra

Re: [PATCH 4/4] utils/rpctrace: escape non-printable characters in strings

2013-12-15 Thread Samuel Thibault
Justus Winter, le Sat 14 Dec 2013 13:42:17 +0100, a écrit : > Quoting Ivan Shmakov (2013-12-13 17:05:19) > > PS. Doesn’t Gnulib provide such a function already? > > Is it ok to use gnulib stuff in the Hurd? In rpctrace it would probably not be a problem. About the code import etc., I don't know

Re: [PATCH 4/4] utils/rpctrace: escape non-printable characters in strings

2013-12-14 Thread Justus Winter
Quoting Ivan Shmakov (2013-12-13 17:05:19) > > Justus Winter <4win...@informatik.uni-hamburg.de> writes: > > > * utils/rpctrace.c (escape_sequences): New char array mapping > > characters to their escape sequence. > > […] > > > +static char escape_sequences[0xff] = > > JFTR: [0xF

Re: [PATCH 4/4] utils/rpctrace: escape non-printable characters in strings

2013-12-13 Thread Ivan Shmakov
> Justus Winter <4win...@informatik.uni-hamburg.de> writes: > * utils/rpctrace.c (escape_sequences): New char array mapping > characters to their escape sequence. […] > +static char escape_sequences[0xff] = JFTR: [0xFF] means [0] through [0xFE]. My guess would be that it

[PATCH 4/4] utils/rpctrace: escape non-printable characters in strings

2013-12-13 Thread Justus Winter
* utils/rpctrace.c (escape_sequences): New char array mapping characters to their escape sequence. (print_data): Escape non-printable characters when printing strings. --- utils/rpctrace.c | 48 ++-- 1 file changed, 46 insertions(+), 2 deletions(-) di