Re: [PATCH 2/5] hurd: Microoptimize sigreturn

2023-04-18 Thread Samuel Thibault
Sergey Bugaev, le mar. 18 avril 2023 13:21:50 +0300, a ecrit: > (Git managed to eat my email -- it both sent an empty one *and* > truncated my local file (what?); so retyping and resending this.) > > On Tue, Apr 18, 2023 at 2:23 AM Samuel Thibault > wrote: > > That doesn't seem to be true, we ge

Re: [PATCH 2/5] hurd: Microoptimize sigreturn

2023-04-18 Thread Sergey Bugaev
(Git managed to eat my email -- it both sent an empty one *and* truncated my local file (what?); so retyping and resending this.) On Tue, Apr 18, 2023 at 2:23 AM Samuel Thibault wrote: > That doesn't seem to be true, we get segfaults with this patch applied > in these tests: > > ./htl/tst-kill6.t

Re: [PATCH 2/5] hurd: Microoptimize sigreturn

2023-04-17 Thread Samuel Thibault
Hello, Sergey Bugaev, le ven. 14 avril 2023 22:36:57 +0300, a ecrit: > - struct hurd_sigstate *ss = _hurd_self_sigstate (); > + struct hurd_sigstate *ss; > + > + /* We know the sigstate must be initialized, That doesn't seem to be true, we get segfaults with this patch applied in these tests:

[PATCH 2/5] hurd: Microoptimize sigreturn

2023-04-14 Thread Sergey Bugaev
Signed-off-by: Sergey Bugaev --- I'll understand if this patch will be rejected, since this is not a hot path. But I just couldn't help myself when I saw what this was being compiled to! Much cleaner now. If you don't like THREAD_GETMEM (THREAD_SELF, _hurd_sigstate), we could have _hurd_self_sig