Re: [PATCH 2/3] i386: add io_map_cached

2014-07-06 Thread Samuel Thibault
Justus Winter, le Tue 01 Jul 2014 11:37:03 +0200, a écrit : > Also, I'm not convinced that undoing the mappings is > necessary, as we're shutting down the system. Well, for that use of the io_map_cached function, yes, but you never know who will want to call that function in the future, e.g. for A

Re: [PATCH 2/3] i386: add io_map_cached

2014-07-01 Thread Justus Winter
Quoting Samuel Thibault (2014-07-01 11:26:19) > Justus Winter, le Tue 01 Jul 2014 11:22:38 +0200, a écrit : > > I don't believe one knows the size in advance. > > In advance, no, but > > > Every acpi table has a header with explicit size information. > > Once you can read this, you can know the

Re: [PATCH 2/3] i386: add io_map_cached

2014-07-01 Thread Samuel Thibault
Justus Winter, le Tue 01 Jul 2014 11:22:38 +0200, a écrit : > I don't believe one knows the size in advance. In advance, no, but > Every acpi table has a header with explicit size information. Once you can read this, you can know the size and can remap, can't you? Samuel

Re: [PATCH 2/3] i386: add io_map_cached

2014-07-01 Thread Justus Winter
Quoting Samuel Thibault (2014-05-23 01:28:30) > Justus Winter, le Thu 15 May 2014 12:32:41 +0200, a écrit : > > Quoting Samuel Thibault (2014-05-15 02:13:13) > > > Justus Winter, le Fri 02 May 2014 21:33:01 +0200, a écrit : > > > > io_map_cached is like io_map, but reuses the old mapping if it is >

Re: [PATCH 2/3] i386: add io_map_cached

2014-05-22 Thread Samuel Thibault
Justus Winter, le Thu 15 May 2014 12:32:41 +0200, a écrit : > Quoting Samuel Thibault (2014-05-15 02:13:13) > > Justus Winter, le Fri 02 May 2014 21:33:01 +0200, a écrit : > > > io_map_cached is like io_map, but reuses the old mapping if it is > > > applicable. > > > > But AIUI, if it is not appli

Re: [PATCH 2/3] i386: add io_map_cached

2014-05-15 Thread Samuel Thibault
Justus Winter, le Thu 15 May 2014 12:32:41 +0200, a écrit : > accessing this physical address with phystokv() fails b/c it is > outside the mapped range Ah, right, I guess it's in very high addresses. Samuel

Re: [PATCH 2/3] i386: add io_map_cached

2014-05-15 Thread Justus Winter
Quoting Samuel Thibault (2014-05-15 02:13:13) > Hello, > > Justus Winter, le Fri 02 May 2014 21:33:01 +0200, a écrit : > > io_map_cached is like io_map, but reuses the old mapping if it is > > applicable. > > But AIUI, if it is not applicable, it does not unmap the previous > mapping, so we lose

Re: [PATCH 2/3] i386: add io_map_cached

2014-05-14 Thread Samuel Thibault
Hello, Justus Winter, le Fri 02 May 2014 21:33:01 +0200, a écrit : > io_map_cached is like io_map, but reuses the old mapping if it is > applicable. But AIUI, if it is not applicable, it does not unmap the previous mapping, so we lose virtual memory. A really transparent io_map_cached seems not

[PATCH 2/3] i386: add io_map_cached

2014-05-02 Thread Justus Winter
io_map_cached is like io_map, but reuses the old mapping if it is applicable. * i386/i386/io_map.c: Add io_map_cached. --- i386/i386/io_map.c | 29 + 1 file changed, 29 insertions(+) diff --git a/i386/i386/io_map.c b/i386/i386/io_map.c index 74e0b47..03d7152 100644 --