Re: [PATCH 2/3] Add the code for starting up the mountee

Hello, On Fri, Aug 07, 2009 at 07:58:34PM +0200, olafbuddenha...@gmx.net wrote: > On Mon, Aug 03, 2009 at 08:20:19PM +0300, Sergiu Ivanov wrote: > > On Sat, Jul 18, 2009 at 06:33:11AM +0200, olafbuddenha...@gmx.net wrote: > > > On Thu, Jul 16, 2009 at 01:04:06PM +0300, Sergiu Ivanov wrote: > > >

Re: [PATCH 2/3] Add the code for starting up the mountee

Hi, On Mon, Aug 03, 2009 at 08:20:19PM +0300, Sergiu Ivanov wrote: > On Sat, Jul 18, 2009 at 06:33:11AM +0200, olafbuddenha...@gmx.net wrote: > > On Thu, Jul 16, 2009 at 01:04:06PM +0300, Sergiu Ivanov wrote: > > And I still don't like "np". > > I looked through unionfs again and I can confirm t

Re: [PATCH 2/3] Add the code for starting up the mountee

Hello, On Tue, Aug 04, 2009 at 01:08:10AM +0200, Thomas Schwinge wrote: > On Mon, Aug 03, 2009 at 08:20:19PM +0300, Sergiu Ivanov wrote: > > On Sat, Jul 18, 2009 at 06:33:11AM +0200, olafbuddenha...@gmx.net wrote: > > > On Thu, Jul 16, 2009 at 01:04:06PM +0300, Sergiu Ivanov wrote: > > > > +/* Sta

Re: [PATCH 2/3] Add the code for starting up the mountee

Hello! On Mon, Aug 03, 2009 at 08:20:19PM +0300, Sergiu Ivanov wrote: > On Sat, Jul 18, 2009 at 06:33:11AM +0200, olafbuddenha...@gmx.net wrote: > > On Thu, Jul 16, 2009 at 01:04:06PM +0300, Sergiu Ivanov wrote: > > > +/* Starts the mountee (given by `argz` and `argz_len`), sets it on > > > + no

Re: [PATCH 2/3] Add the code for starting up the mountee

Hello, On Sat, Jul 18, 2009 at 06:33:11AM +0200, olafbuddenha...@gmx.net wrote: > On Thu, Jul 16, 2009 at 01:04:06PM +0300, Sergiu Ivanov wrote: > > +/* The node the mountee is sitting on. */ > > +node_t * unionmount_proxy; > > + > > +mach_port_t mountee_port; > > This is the control port of the

Re: [PATCH 2/3] Add the code for starting up the mountee

Hello, On Sat, Jul 18, 2009 at 04:22:36AM +0200, olafbuddenha...@gmx.net wrote: > On Thu, Jul 16, 2009 at 10:41:34PM +0300, Sergiu Ivanov wrote: > > On Fri, Jul 10, 2009 at 04:17:23AM +0200, olafbuddenha...@gmx.net > > wrote: > > > On Sun, Jul 05, 2009 at 07:10:48PM +0300, Sergiu Ivanov wrote: >

Re: [PATCH 2/3] Add the code for starting up the mountee

Hi, On Thu, Jul 16, 2009 at 10:41:34PM +0300, Sergiu Ivanov wrote: > On Fri, Jul 10, 2009 at 04:17:23AM +0200, olafbuddenha...@gmx.net > wrote: > > On Sun, Jul 05, 2009 at 07:10:48PM +0300, Sergiu Ivanov wrote: > > > I met this style (using intermediate variables) quite often in > > > unionfs and

Re: [PATCH 2/3] Add the code for starting up the mountee

Hi, On Thu, Jul 16, 2009 at 01:04:06PM +0300, Sergiu Ivanov wrote: > diff --git a/mount.c b/mount.c > index 7bc1fb8..7e134d6 100644 > --- a/mount.c > +++ b/mount.c > @@ -22,8 +22,200 @@ > > #define _GNU_SOURCE > > +#include > +#include > + > #include "mount.h" > +#include "lib.h" > > /

Re: [PATCH 2/3] Add the code for starting up the mountee

Hello, On Fri, Jul 10, 2009 at 07:10:07PM +0200, Carl Fredrik Hammar wrote: > On Fri, Jul 10, 2009 at 04:17:23AM +0200, olafbuddenha...@gmx.net wrote: > > > > > + /*Opens the port on which to set the new translator */ > > > > > + error_t > > > > > +open_port > > > > > +(int flags, mach_p

Re: [PATCH 2/3] Add the code for starting up the mountee

Hello, On Fri, Jul 10, 2009 at 04:17:23AM +0200, olafbuddenha...@gmx.net wrote: > On Sun, Jul 05, 2009 at 07:10:48PM +0300, Sergiu Ivanov wrote: > > On Fri, Jul 03, 2009 at 08:07:01PM +0200, olafbuddenha...@gmx.net wrote: > > > > > + /*This is actually the end of initialization, so if somet

Re: [PATCH 2/3] Add the code for starting up the mountee

>From 3e115d794301c7c8966c077e1e7da40752821574 Mon Sep 17 00:00:00 2001 From: Sergiu Ivanov Date: Sun, 5 Jul 2009 23:08:44 +0300 Subject: [PATCH] Start the mountee in a lazy fashion. * mount.c (unionmount_proxy): New variable. (mountee_port): Likewise. (mountee_started): Likewise. (setup_unionmou

Re: [PATCH 2/3] Add the code for starting up the mountee

Hi, On Fri, Jul 10, 2009 at 04:17:23AM +0200, olafbuddenha...@gmx.net wrote: > > > > + /*Opens the port on which to set the new translator */ > > > > + error_t > > > > +open_port > > > > +(int flags, mach_port_t * underlying, > > > > + mach_msg_type_name_t * underlying_type, task_t t

Re: [PATCH 2/3] Add the code for starting up the mountee

Hi, On Sun, Jul 05, 2009 at 07:10:48PM +0300, Sergiu Ivanov wrote: > On Fri, Jul 03, 2009 at 08:07:01PM +0200, olafbuddenha...@gmx.net wrote: > > > + /*This is actually the end of initialization, so if something > > > + goes bad here we are rightful to die. And, of course, > > > + unionmount

Re: [PATCH 2/3] Add the code for starting up the mountee

Hello, To avoid redundant text, I'll state beforehand that everything I didn't comment on I had corrected in the patches I had sent in several minutes before. One remark on the comments in the unionmount_start_mountee function: this code I borrowed from nsmux with little change, which means that

Re: [PATCH 2/3] Add the code for starting up the mountee

Hi, On Thu, Jun 11, 2009 at 09:19:21PM +0300, Sergiu Ivanov wrote: > * netfs.c: Update copyright years. > (netfs_S_dir_lookup): Add the code for starting up the mountee > at the first invocation. Just "Start up mountee on first invocation" is probably better. > (netfs_get_dirents): Likewise. >

[PATCH 2/3] Add the code for starting up the mountee

>From feb8c6ff2c42f0d0f556aa1eb1b033cb875d5f2f Mon Sep 17 00:00:00 2001 From: Sergiu Ivanov Date: Thu, 11 Jun 2009 17:09:38 +0300 Subject: [PATCH] Add the code for starting up the mountee. * netfs.c: Update copyright years. (netfs_S_dir_lookup): Add the code for starting up the mountee at the fir