Re: [PATCH 1/6] libfshelp_rlock

2016-12-20 Thread Samuel Thibault
Svante Signell, on Tue 20 Dec 2016 09:50:54 +0100, wrote: > On Tue, 2016-12-20 at 02:03 +0100, Samuel Thibault wrote: > > Svante Signell, on Thu 15 Dec 2016 12:31:55 +0100, wrote: > > > On Thu, 2015-03-05 at 02:34 +0100, Samuel Thibault wrote: > > > >  > > No, I'm unsure what we want: do we trust t

Re: [PATCH 1/6] libfshelp_rlock

2016-12-20 Thread Svante Signell
On Tue, 2016-12-20 at 02:03 +0100, Samuel Thibault wrote: > Hello, >  > Svante Signell, on Mon 19 Dec 2016 18:25:58 +0100, wrote: > > It seems like the open mode for /dev/null does not contain O_READ/O_WRITE > > flags > > ? It does, see cred->po->openmodes. Seems to be a difference between libdisk

Re: [PATCH 1/6] libfshelp_rlock

2016-12-20 Thread Svante Signell
On Tue, 2016-12-20 at 02:03 +0100, Samuel Thibault wrote: > Hello, > > Svante Signell, on Thu 15 Dec 2016 12:31:55 +0100, wrote: > > On Thu, 2015-03-05 at 02:34 +0100, Samuel Thibault wrote: > > >  > No, I'm unsure what we want: do we trust the FS server as to provide > the proper l_pid, just like

Re: [PATCH 1/6] libfshelp_rlock

2016-12-19 Thread Samuel Thibault
Hello, Svante Signell, on Thu 15 Dec 2016 12:31:55 +0100, wrote: > On Thu, 2015-03-05 at 02:34 +0100, Samuel Thibault wrote: > > Olaf was wondering about flock being reimplemented over this new > > implementation.  It's actually a tricky question.  I believe there are > > two issues: > > > > > >

Re: [PATCH 1/6] libfshelp_rlock

2016-12-15 Thread Svante Signell
On Thu, 2015-03-05 at 02:34 +0100, Samuel Thibault wrote: > Olaf was wondering about flock being reimplemented over this new > implementation.  It's actually a tricky question.  I believe there are > two issues: > > > All in all, I'd suggest the following: ... > - let's make GETLK however return

Re: [PATCH 1/6] libfshelp_rlock

2015-03-04 Thread Samuel Thibault
Olaf was wondering about flock being reimplemented over this new implementation. It's actually a tricky question. I believe there are two issues: Are lockf/fcntl/flock supposed to interact or be independent? On Linux, lockf and fcntl interact, and flock is independent from the two others. On BS

Re: [PATCH 1/6] libfshelp_rlock

2015-03-04 Thread Samuel Thibault
Hello, Svante Signell, le Thu 22 Jan 2015 10:29:52 +0100, a écrit : > --- /dev/null > +++ b/libfshelp/rlock.h > @@ -0,0 +1,117 @@ > + > +#ifndef FSHELP_RLOCK_H > +#define FSHELP_RLOCK_H > + > +//#include Why not? That'd avoid copy/pasting the pthread_cond_init > +extern int pthread_cond_init (

[PATCH 1/6] libfshelp_rlock

2015-01-22 Thread Svante Signell
libfshelp/ChangeLog 2014-08-21 Svante Signell * Makefile: Link with pthread * define temporary CPP_FLAGS until glibc is updated * rlock-drop-peropen.c: Port from cthreads to libpthread. * rlock-tweak.c: Likewise * fshelp.h: Likewise * rlock.h: Like