Re: [PATCH 1/2] device/net_io.c: add comments and initialize hash_entp

2013-12-02 Thread Samuel Thibault
Justus Winter, le Mon 02 Dec 2013 14:10:56 +0100, a écrit : > Quoting Marin Ramesa (2013-12-02 11:55:14) > > On 02.12.2013 10:37:08, Justus Winter wrote: > > > The other day you were fixing this kind of code, now you're > > > introducing it. Maybe there's a better way to silence this warning, > > >

Re: [PATCH 1/2] device/net_io.c: add comments and initialize hash_entp

2013-12-02 Thread Justus Winter
Quoting Marin Ramesa (2013-12-02 11:55:14) > On 02.12.2013 10:37:08, Justus Winter wrote: > > The other day you were fixing this kind of code, now you're > > introducing it. Maybe there's a better way to silence this warning, > > maybe some attribute. > > Maybe initialize to some kind of a templat

Re: [PATCH 1/2] device/net_io.c: add comments and initialize hash_entp

2013-12-02 Thread Marin Ramesa
On 02.12.2013 11:55:14, Marin Ramesa wrote: > +for (counter = 0; i < N_NET_HASH_KEYS; i++) This should be: for (counter = 0; counter < N_NET_HASH_KEYS; counter++);

Re: [PATCH 1/2] device/net_io.c: add comments and initialize hash_entp

2013-12-02 Thread Marin Ramesa
On 02.12.2013 10:37:08, Justus Winter wrote: > The other day you were fixing this kind of code, now you're > introducing it. Maybe there's a better way to silence this warning, > maybe some attribute. Maybe initialize to some kind of a template, like this: From 0b850181995519071d3064c45dbbc31b762

Re: [PATCH 1/2] device/net_io.c: add comments and initialize hash_entp

2013-12-02 Thread Justus Winter
Quoting Marin Ramesa (2013-12-02 09:14:35) > Samuel Thibault wrote: > > It doesn't seem so clear that it's actually always properly initialized. > > We also need a comment explaining why it always is. > > * device/net_io.c (hash_entp): Initialize and add a comment saying why this > was done. > >

[PATCH 1/2] device/net_io.c: add comments and initialize hash_entp

2013-12-02 Thread Marin Ramesa
Samuel Thibault wrote: > It doesn't seem so clear that it's actually always properly initialized. > We also need a comment explaining why it always is. * device/net_io.c (hash_entp): Initialize and add a comment saying why this was done. --- device/net_io.c | 7 +-- 1 file changed, 5 insert