Hi,
On Thu, Dec 24, 2009 at 10:25:47PM +0200, Sergiu Ivanov wrote:
> Still, I somehow feel bad about copying from a pointer without doing
> an extra check. Would it be an acceptable idea to assert (name) ?
Sure: if you think that something *should* be a certain way (non-NULL in
this case), but
Hello,
On Mon, Aug 10, 2009 at 11:11:41PM +0300, Sergiu Ivanov wrote:
>
> diff --git a/eth-multiplexer/vdev.c b/eth-multiplexer/vdev.c
> index dac9802..6fb88d0 100644
> --- a/eth-multiplexer/vdev.c
> +++ b/eth-multiplexer/vdev.c
> @@ -135,7 +135,10 @@ add_vdev (char *name, int size,
>
>vdev-
Hello,
On Wed, Aug 12, 2009 at 02:42:59PM +0200, olafbuddenha...@gmx.net wrote:
> On Mon, Aug 10, 2009 at 11:11:41PM +0300, Sergiu Ivanov wrote:
>
> > * eth-multiplexer/device_impl.c (ds_device_open): Check if
> > openstat flags are a subset of mode flags (not conversely).
> > * eth-multiplexer/v
Hi,
On Mon, Aug 10, 2009 at 11:11:41PM +0300, Sergiu Ivanov wrote:
> * eth-multiplexer/device_impl.c (ds_device_open): Check if
> openstat flags are a subset of mode flags (not conversely).
> * eth-multiplexer/vdev.c (add_vdev): Copy name only if it
> is not NULL.
Why are you putting these two c
>From 3f7c8c06d40b587c1d455ed69a31984d5995c33b Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov
Date: Tue, 4 Aug 2009 15:09:21 +0300
Subject: [PATCH] Fix some minor issues.
* eth-multiplexer/device_impl.c (ds_device_open): Check if
openstat flags are a subset of mode flags (not conversely).
* eth-mul
