Re: [PATCH-1] A new irq device interface

2020-08-02 Thread Junling Ma
Ok. Will do. Junling > On Aug 2, 2020, at 4:52 PM, Samuel Thibault wrote: > > Junling Ma, le dim. 02 août 2020 16:45:22 -0700, a ecrit: >> I guess you misunderstood what I mean. I mean that there seems to be no >> interest in the discussion on IRC yesterday that we introduce a new scheme. > >

Re: [PATCH-1] A new irq device interface

2020-08-02 Thread Samuel Thibault
Junling Ma, le dim. 02 août 2020 16:45:22 -0700, a ecrit: > I guess you misunderstood what I mean. I mean that there seems to be no > interest in the discussion on IRC yesterday that we introduce a new scheme. That's because you asked on IRC at a random time. That's what IRC is not good at: coll

Re: [PATCH-1] A new irq device interface

2020-08-02 Thread Junling Ma
I guess you misunderstood what I mean. I mean that there seems to be no interest in the discussion on IRC yesterday that we introduce a new scheme. If so, I will not work on that part. For part I, ie., moving the irq management to mach side, it people think it is useful, I will prepare a series

Re: [PATCH-1] A new irq device interface

2020-08-02 Thread Samuel Thibault
Samuel Thibault, le lun. 03 août 2020 01:33:53 +0200, a ecrit: > Junling Ma, le dim. 02 août 2020 16:19:39 -0700, a ecrit: > > You may have missed the part where I say let user side [/dev/irq*] > > translator > > do the multiplexing. > > I didn't but that looks like extra complexity, and makes th

Re: [PATCH-1] A new irq device interface

2020-08-02 Thread Samuel Thibault
Junling Ma, le dim. 02 août 2020 16:19:39 -0700, a ecrit: > I was distracted by using a counter at all in the original code, > because an irq cannot be fired more than once before it is acked. Right, normally that doesn't happen. > What we really need is a boolean_t type per notification, And th

Re: [PATCH-1] A new irq device interface

2020-08-02 Thread Junling Ma
> On Aug 2, 2020, at 3:44 PM, Samuel Thibault wrote: > > Junling Ma, le dim. 02 août 2020 15:32:01 -0700, a ecrit: 1. Change devicer_user_intr to be a linux interrupt handler. >>> >>> Right, this makes sense, but did you actually try it? Check the existing >>> code twice to realize why it'

Re: [PATCH-1] A new irq device interface

2020-08-02 Thread Samuel Thibault
Junling Ma, le dim. 02 août 2020 15:32:01 -0700, a ecrit: > >> 1. Change devicer_user_intr to be a linux interrupt handler. > > > > Right, this makes sense, but did you actually try it? Check the existing > > code twice to realize why it's done that way. Here linux_intr is looking > > through the

Re: [PATCH-1] A new irq device interface

2020-08-02 Thread Junling Ma
Hi Samual, Thanks for reviewing. > Junling Ma, le sam. 01 août 2020 18:59:58 -0700, a ecrit: >> PATCH 1 is included in this email: it prepares the stage by > > Please provide separate patches for each over these. Otherwise this is > all conflated and way more difficult to review. Ok. >> 1. Ch

Re: [PATCH-1] A new irq device interface

2020-08-02 Thread Samuel Thibault
Hello, Junling Ma, le sam. 01 août 2020 18:59:58 -0700, a ecrit: > PATCH 1 is included in this email: it prepares the stage by Please provide separate patches for each over these. Otherwise this is all conflated and way more difficult to review. > 1. Change devicer_user_intr to be a linux interr

[PATCH-1] A new irq device interface

2020-08-01 Thread Junling Ma
Hi all, When I am playing with the current irq device and user interrupt handling, I see that each device must implement the device_intr_register and device_intr_ack calls. However, they are only meaningful for the irq device. So when writing device translators, this seems a little confusing to