Re: [PATCH] utils/mount: canonicalize mountpoints

On Fri, Nov 21, 2014 at 4:12 AM, Samuel Thibault wrote: > Could you try the patch I have just pushed? I believe it should be > doing the right thing. I confirm it fixes pathnames. Thanks -- G..e

Re: [PATCH] utils/mount: canonicalize mountpoints

Hello, Could you try the patch I have just pushed? I believe it should be doing the right thing. Samuel

Re: [PATCH] utils/mount: canonicalize mountpoints

Getting back to this old thread so we may get pbuilder to work... Samuel Thibault, le Sat 14 Jun 2014 22:44:56 +0200, a écrit : > Gabriele Giacone, le Thu 05 Jun 2014 00:34:45 +0200, a écrit : > > * utils/mount.c (main): realpath mountpoint. > > * utils/umount.c (do_umount): Likewise. > > Mmm, bu

Re: [PATCH] utils/mount: canonicalize mountpoints

Quoting Gabriele Giacone (2014-06-16 00:25:53) > On Sun, Jun 15, 2014 at 5:41 PM, Justus Winter > <4win...@informatik.uni-hamburg.de> wrote: > > Quoting Gabriele Giacone (2014-06-15 12:56:13) > >> >> Such hunks are workarounds at the moment because hurd mounts paths by > >> >> keeping superfluous '

Re: [PATCH] utils/mount: canonicalize mountpoints

On Sun, Jun 15, 2014 at 5:41 PM, Justus Winter <4win...@informatik.uni-hamburg.de> wrote: > Quoting Gabriele Giacone (2014-06-15 12:56:13) >> >> Such hunks are workarounds at the moment because hurd mounts paths by >> >> keeping superfluous '/' and '.' in pathnames if specified at mount >> >> time,

Re: [PATCH] utils/mount: canonicalize mountpoints

Quoting Gabriele Giacone (2014-06-15 12:56:13) > >> Such hunks are workarounds at the moment because hurd mounts paths by > >> keeping superfluous '/' and '.' in pathnames if specified at mount > >> time, which need to be specified at umount time as well to umount > >> successfully. > > > > But the

Re: [PATCH] utils/mount: canonicalize mountpoints

On Sun, Jun 15, 2014 at 8:32 AM, Samuel Thibault wrote: > Gabriele Giacone, le Sun 15 Jun 2014 02:23:49 +0200, a écrit : >> On Sun, Jun 15, 2014 at 1:59 AM, Samuel Thibault >> wrote: >> I thought it was already detailed enough: first and last hunks useless >> if patch is applied are: > > That's o

Re: [PATCH] utils/mount: canonicalize mountpoints

Gabriele Giacone, le Sun 15 Jun 2014 02:23:49 +0200, a écrit : > On Sun, Jun 15, 2014 at 1:59 AM, Samuel Thibault > wrote: > > Gabriele Giacone, le Sun 15 Jun 2014 01:28:06 +0200, a écrit : > >> ... this one would fix malformed mount/umount input paths (another > >> source. Any else? raw settrans)

Re: [PATCH] utils/mount: canonicalize mountpoints

On Sun, Jun 15, 2014 at 1:59 AM, Samuel Thibault wrote: > Gabriele Giacone, le Sun 15 Jun 2014 01:28:06 +0200, a écrit : >> ... this one would fix malformed mount/umount input paths (another >> source. Any else? raw settrans). It would make first and last hunks in >> pbuilder.diff [0] useless. >>

Re: [PATCH] utils/mount: canonicalize mountpoints

Gabriele Giacone, le Sun 15 Jun 2014 01:28:06 +0200, a écrit : > > Mmm, but sutils/fstab.c already does apply realpath, doesn't it? I see > > it doing it in fstab_find. > > In fstab_find, it just helps finding paths in fstab so that it looks > for both input one as-is and input one realpath'ed. I

Re: [PATCH] utils/mount: canonicalize mountpoints

On Sat, Jun 14, 2014 at 10:44 PM, Samuel Thibault wrote: > Gabriele Giacone, le Thu 05 Jun 2014 00:34:45 +0200, a écrit : >> * utils/mount.c (main): realpath mountpoint. >> * utils/umount.c (do_umount): Likewise. > > Mmm, but sutils/fstab.c already does apply realpath, doesn't it? I see > it doin

Re: [PATCH] utils/mount: canonicalize mountpoints

Gabriele Giacone, le Thu 05 Jun 2014 00:34:45 +0200, a écrit : > * utils/mount.c (main): realpath mountpoint. > * utils/umount.c (do_umount): Likewise. Mmm, but sutils/fstab.c already does apply realpath, doesn't it? I see it doing it in fstab_find. What would this be needed for? Don't explain

[PATCH] utils/mount: canonicalize mountpoints

* utils/mount.c (main): realpath mountpoint. * utils/umount.c (do_umount): Likewise. --- utils/mount.c | 7 +++ utils/umount.c | 7 +++ 2 files changed, 14 insertions(+) diff --git a/utils/mount.c b/utils/mount.c index df77c66..c14e073 100644 --- a/utils/mount.c +++ b/utils/mount.c @@ -5