Re: [PATCH] libdiskfs: merge of init-first.c and init-main.c

2001-04-12 Thread Neal H Walfield
> > diskfs_init_main calls diskfs_init_diskfs itself. Therefore, having > > diskfs_init_diskfs as a public interface is useless especially with its > > current comment. Additionally, diskfs_init_main is the only caller of > > diskfs_init_diskfs. > > You are mistaken. If you would like to make

Re: [PATCH] libdiskfs: merge of init-first.c and init-main.c

2001-03-31 Thread Roland McGrath
> Calling diskfs_init_main is mandatory. This is wrong. diskfs_init_main is a convenience function for diskfs filesystems that use a store, and can be the bootstrap filesystem. A diskfs filesystem not taking a store argument cannot use diskfs_init_main. Take for example tmpfs. > diskfs_init_

[PATCH] libdiskfs: merge of init-first.c and init-main.c

2001-03-31 Thread Neal H Walfield
Calling diskfs_init_main is mandatory. diskfs_init_main calls diskfs_init_diskfs itself. Therefore, having diskfs_init_diskfs as a public interface is useless especially with its current comment. Additionally, diskfs_init_main is the only caller of diskfs_init_diskfs. Thus, this patch merges d