Marin Ramesa, le Sat 07 Sep 2013 19:02:09 +0200, a écrit :
> I completely misunderstood the code and the simple locks. No patch is
> needed and there is no real bug. Sorry if I have taken up your time.
No problem: teaching something to potential contributors is already a
good thing :)
Samuel
On 07.09.2013 10:46:18, Samuel Thibault wrote:
> Marin Ramesa, le Sat 07 Sep 2013 10:17:29 +0200, a écrit :
> > We have a local variable mqueue that is set by the lock, but if you
> > look at the definition of imq_unlock() and then simple_unlock()
> > members of mqueue just change state and they d
On 07.09.2013 10:46:18, Samuel Thibault wrote:
> > And in the end mqueue never get's really used in the
> > ipc_port_set_seqno().
>
> It is, for locking.
That's what I mean by "not functional". I claim it doesn't perform
locking in that one special case. But I was too hasty with the patch,
I'll
Marin Ramesa, le Sat 07 Sep 2013 10:17:29 +0200, a écrit :
> On 07.09.2013 08:58:14, Samuel Thibault wrote:
> > Marin Ramesa, le Sat 07 Sep 2013 08:00:47 +0200, a écrit :
> > > * ipc/ipc_port.c (ipc_port_set_seqno) [MACH_SLOCKS]: Conditional
> > > locking.
> >
> > What is the rationale? Does it r
On 07.09.2013 08:58:14, Samuel Thibault wrote:
> Marin Ramesa, le Sat 07 Sep 2013 08:00:47 +0200, a écrit :
> > * ipc/ipc_port.c (ipc_port_set_seqno) [MACH_SLOCKS]: Conditional
> > locking.
>
> What is the rationale? Does it really bring an noticeable
> improvement? The locking is already conditi
Marin Ramesa, le Sat 07 Sep 2013 08:00:47 +0200, a écrit :
> * ipc/ipc_port.c (ipc_port_set_seqno) [MACH_SLOCKS]: Conditional locking.
What is the rationale? Does it really bring an noticeable improvement?
The locking is already conditional inside ipc_port_lock_mqueue, from the
simple_*lock* macr
* ipc/ipc_port.c (ipc_port_set_seqno) [MACH_SLOCKS]: Conditional locking.
=46rom d56b769755a5d671f084ebdd482de8b34be9cd5b Mon Sep 17 00:00:00 2001
From: Marin Ramesa
Date: Sat, 7 Sep 2013 07:37:42 +0200
Subject: [PATCH] perform conditional locking while changing the port sequence
number
---
ipc
