Re: [PATCH] include: fix the definition of device_open

2014-04-12 Thread Samuel Thibault
Justus Winter, le Fri 11 Apr 2014 09:32:30 +0200, a écrit : > Previously, every userspace server implementing the device protocol > filtered the device definitions to replace the device_t type with > mach_port_send_t to make the device argument of device_open > polymorphic. Rather than doing that,

Re: [PATCH] include: fix the definition of device_open

2014-04-12 Thread Samuel Thibault
Justus Winter, le Sat 12 Apr 2014 09:13:00 +0200, a écrit : > So the current definition of device_open breaks even the most straight > forward way to implement a device server. In contrast, Hurds > dir_lookup gets this right: Indeed, that's what I was seeing :) Samuel

Re: [PATCH] include: fix the definition of device_open

2014-04-12 Thread Justus Winter
Quoting Justus Winter (2014-04-11 23:11:59) > Quoting Samuel Thibault (2014-04-11 22:27:09) > > Justus Winter, le Fri 11 Apr 2014 09:32:30 +0200, a écrit : > > > Previously, every userspace server implementing the device protocol > > > filtered the device definitions to replace the device_t type wi

Re: [PATCH] include: fix the definition of device_open

2014-04-11 Thread Justus Winter
Quoting Samuel Thibault (2014-04-11 22:27:09) > Justus Winter, le Fri 11 Apr 2014 09:32:30 +0200, a écrit : > > Previously, every userspace server implementing the device protocol > > filtered the device definitions to replace the device_t type with > > mach_port_send_t to make the device argument

Re: [PATCH] include: fix the definition of device_open

2014-04-11 Thread Samuel Thibault
Justus Winter, le Fri 11 Apr 2014 09:32:30 +0200, a écrit : > Previously, every userspace server implementing the device protocol > filtered the device definitions to replace the device_t type with > mach_port_send_t to make the device argument of device_open > polymorphic. Rather than doing that,

[PATCH] include: fix the definition of device_open

2014-04-11 Thread Justus Winter
Previously, every userspace server implementing the device protocol filtered the device definitions to replace the device_t type with mach_port_send_t to make the device argument of device_open polymorphic. Rather than doing that, which makes it impossible to use translation functions, fix the def