Re: [PATCH] diskpart

2001-01-23 Thread Roland McGrath
> Ok, ch* on the root node changes all of the nodes and a ch* on any of > the leaf nodes returns EROFS. Reasonable? Sounds ok to me. > I started exploring it about two weeks ago; it is well written (wrt > being os-independent). Thus, I imagine that we could use that. I am in favor of using (a

Re: [PATCH] diskpart

2001-01-23 Thread Neal H Walfield
> > What do you recommend happen when one does a chown part/1? How about > > a chown part? Should they effect the entire tree? > > Eh, whatever. I think it would be ok for these to fail with EOPNOTSUPP. > Changing the root node would be ok too, but probably surprising to someone > who thought

Re: [PATCH] diskpart

2001-01-23 Thread Roland McGrath
> > * netfs_check_open_permissions ought to do an fshelp_access check. > > In fact, you ought to make it refuse if O_READ or O_WRITE is set; > > then it will be impossible to reach the netfs_attempt_{read,write} > > hooks and you can make those call abort or use assert. > > What error shoul

Re: [PATCH] diskpart

2001-01-23 Thread Neal H Walfield
> > > Now, some comments about the small behaviors of the filesystem hooks. > > * netfs_check_open_permissions ought to do an fshelp_access check. > In fact, you ought to make it refuse if O_READ or O_WRITE is set; > then it will be impossible to reach the netfs_attempt_{read,write} > hoo

Re: [PATCH] diskpart

2001-01-16 Thread Neal H Walfield
On Tue, Jan 16, 2001 at 03:55:16AM -0500, Roland McGrath wrote: > Marcus has made some changes to libstore and gnumach that should make it > handle disks up to a terabyte or two. If you have the most recent gnumach > (with a 2001-01-09 ChangeLog entry), and hurd (which you are evidently > buildin

Re: [PATCH] diskpart

2001-01-16 Thread Jeff Bailey
On Tue, Jan 16, 2001 at 03:55:16AM -0500, Roland McGrath wrote: > Marcus has made some changes to libstore and gnumach that should make it > handle disks up to a terabyte or two. If you have the most recent gnumach > (with a 2001-01-09 ChangeLog entry), and hurd (which you are evidently > buildin

Re: [PATCH] diskpart

2001-01-16 Thread Roland McGrath
I have a variety of things to say about the work you've done here. The first thing is that I'm very glad to see that you have taken on a project like this and gotten nominally working. This is a fine way for you and others who read your code to get a good understanding of how to write Hurd compo

Re: [PATCH] diskpart

2001-01-16 Thread Roland McGrath
Marcus has made some changes to libstore and gnumach that should make it handle disks up to a terabyte or two. If you have the most recent gnumach (with a 2001-01-09 ChangeLog entry), and hurd (which you are evidently building yourself, so just get current hurd from cvs), then libstore ought to w

Re: [PATCH] diskpart

2001-01-15 Thread Neal H Walfield
On Tue, Jan 16, 2001 at 05:07:11AM +0100, Marcus Brinkmann wrote: > On Mon, Jan 15, 2001 at 10:48:17PM -0500, Neal H Walfield wrote: > > Diskpart suffers from a limitation inherent in the store remap class > > in that it cannot access partitions beyond the 4 GB offset. > > You are talking about t

Re: [PATCH] diskpart

2001-01-15 Thread Marcus Brinkmann
On Mon, Jan 15, 2001 at 10:48:17PM -0500, Neal H Walfield wrote: > Diskpart suffers from a limitation inherent in the store remap class > in that it cannot access partitions beyond the 4 GB offset. You are talking about the file_get_storage_info RPC which has off_t as type for the offset array, r

[PATCH] diskpart

2001-01-15 Thread Neal H Walfield
This adds the diskpart library and translator to the hurd along with the partinfo utility. This patch relies on my previous libnetfs patch. I have tested this on both FreeBSD UFS partitions and Linux ext2 partitions. This will not work with OpenBSD; someone else might want to add this. Diskpar