Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-12-26 Thread Samuel Thibault
Hello, Joan Lledó, le sam. 21 déc. 2019 14:09:04 +0100, a ecrit: > El 1/12/19 a les 1:10, Damien Zammit ha escrit: > > libpciaccess 0.16-1+hurd.1 is still broken on rumpdisk. Somehow the 2 > > applied patches > > don't allow probing of AHCI to occur in rump_init(). > > I've packaged rump libs in

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-12-21 Thread Joan Lledó via Bug reports for the GNU Hurd
Hi, El 1/12/19 a les 1:10, Damien Zammit ha escrit: > libpciaccess 0.16-1+hurd.1 is still broken on rumpdisk. Somehow the 2 > applied patches > don't allow probing of AHCI to occur in rump_init(). > I've packaged rump libs into a debian package following Robert Millan's work > and sent it to Sam

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-30 Thread Damien Zammit
On 30/11/19 9:06 pm, Joan Lledó wrote: > Hi, > > What about this? Do I send the PR? Is there any alternative for the > weak reference? > > El dt. 26 de 11 de 2019 a les 22:53 +0100, en/na Samuel Thibault va > escriure: >> Joan Lledó, le lun. 25 nov. 2019 10:02:55 +0100, a ecrit: >>> 2- Didn't mak

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-30 Thread Joan Lledó via Bug reports for the GNU Hurd
Hi, What about this? Do I send the PR? Is there any alternative for the weak reference? El dt. 26 de 11 de 2019 a les 22:53 +0100, en/na Samuel Thibault va escriure: > Joan Lledó, le lun. 25 nov. 2019 10:02:55 +0100, a ecrit: > > 2- Didn't make any PR b/c I was waiting for comments. > > Ok, now

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-26 Thread Samuel Thibault
Joan Lledó, le lun. 25 nov. 2019 10:02:55 +0100, a ecrit: > 2- Didn't make any PR b/c I was waiting for comments. Ok, now I'm on par with the various changes, thanks for clearing things up :) It looks good, I believe it can be submitted upstream after Damien confirms we are on par with the variou

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-25 Thread Joan Lledó via Bug reports for the GNU Hurd
Hi, I'll try to clear things: 1- I wrote this patch from and for 0.16 in upstream: https://gitlab.freedesktop.org/xorg/lib/libpciaccess 2- Didn't make any PR b/c I was waiting for comments. 3- Didn't thought on Debian at all. 4- If using a weak reference is not good enough for upstream, OK, w

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-25 Thread Damien Zammit
On 25/11/19 9:51 am, Joan Lledó wrote: > El dg. 24 de 11 de 2019 a les 21:17 +0100, en/na Samuel Thibault va > escriure: >> AIUI, apart from my changes, these are the changes which are already >> upstream? > > No, none of this changes are upstream. Joan, I think you are getting confused where is

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-24 Thread Samuel Thibault
Joan Lledó, le dim. 24 nov. 2019 23:51:45 +0100, a ecrit: > El dg. 24 de 11 de 2019 a les 21:17 +0100, en/na Samuel Thibault va > escriure: > > AIUI, apart from my changes, these are the changes which are already > > upstream? > > No, none of this changes are upstream. Then I'm completely lost be

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-24 Thread Joan Lledó
Hi, El dg. 24 de 11 de 2019 a les 21:17 +0100, en/na Samuel Thibault va escriure: > AIUI, apart from my changes, these are the changes which are already > upstream? No, none of this changes are upstream. > I have separated them out and uploaded version +hurd.4. For the Debian package? I'm sorry

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-24 Thread Samuel Thibault
Hello, Joan Lledó, le dim. 24 nov. 2019 20:53:29 +0100, a ecrit: > This patch for libpciaccess includes Samuel's changes and closedir() > calls. AIUI, apart from my changes, these are the changes which are already upstream? Please avoid mixing several things in the same patch. I have separated th

[PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-24 Thread Joan Lledó via Bug reports for the GNU Hurd
From: Joan Lledó --- src/hurd_pci.c | 153 + 1 file changed, 91 insertions(+), 62 deletions(-) diff --git a/src/hurd_pci.c b/src/hurd_pci.c index 28bef16..26505f3 100644 --- a/src/hurd_pci.c +++ b/src/hurd_pci.c @@ -304,8 +304,8 @@ pci_device_hurd

[PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-24 Thread Joan Lledó
Hello, This patch for libpciaccess includes Samuel's changes and closedir() calls.

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-03 Thread Samuel Thibault
Samuel Thibault, le dim. 03 nov. 2019 20:42:27 +0100, a ecrit: > Samuel Thibault, le dim. 03 nov. 2019 20:07:46 +0100, a ecrit: > > I tried the hack I mentioned previously (attached), to properly detect > > that we are the PCI arbiter. Now my system boots, but that's because > > netdde crashes inst

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-03 Thread Samuel Thibault
Samuel Thibault, le dim. 03 nov. 2019 20:07:46 +0100, a ecrit: > I tried the hack I mentioned previously (attached), to properly detect > that we are the PCI arbiter. Now my system boots, but that's because > netdde crashes instead of just hanging. It looks like it does not manage > to use the PCI

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-03 Thread Samuel Thibault
Samuel Thibault, le dim. 03 nov. 2019 18:58:57 +0100, a ecrit: > Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019 18:49:08 > +0100, a ecrit: > > Take a look at hurd_pci.c:452 [1] > > > > /* If we can open pci cfg io ports on hurd, > > * we are the arbiter, therefore t

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-03 Thread Samuel Thibault
Samuel Thibault, le dim. 03 nov. 2019 18:58:57 +0100, a ecrit: > let the pci arbiter notice that it is connecting to itself, Except that this is not an easy task, since the translator is starting and doesn't process messages yet. A hackish way would be to have pci-arbiter define a variable that th

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-03 Thread Samuel Thibault
Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019 18:49:08 +0100, a ecrit: > El 3/11/19 a les 17:10, Samuel Thibault ha escrit: > >> +if (!devices) > >> +return ENOMEM; > > > > That makes me realize: we need to closedir(dir). > > What do you mean?

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-03 Thread Joan Lledó via Bug reports for the GNU Hurd
Hi, El 3/11/19 a les 17:10, Samuel Thibault ha escrit: >> +if (!devices) >> +return ENOMEM; > > That makes me realize: we need to closedir(dir). What do you mean? >> if (err) { >> -mach_port_deallocate (mach_task_self (), pci_server_port); >> -/*

Re: [PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-03 Thread Samuel Thibault
Hello, Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019 11:00:56 +0100, a ecrit: > +devices = realloc(pci_sys->devices, (pci_sys->num_devices + 1) > + * sizeof(struct pci_device_private)); Yes, this looks like a simpler approach. Sure

[PATCH] Hurd: avoid using the deprecated RPC pci_get_ndevs()

2019-11-03 Thread Joan Lledó via Bug reports for the GNU Hurd
From: Joan Lledó --- src/hurd_pci.c | 83 +- 1 file changed, 34 insertions(+), 49 deletions(-) diff --git a/src/hurd_pci.c b/src/hurd_pci.c index 28bef16..98bf83e 100644 --- a/src/hurd_pci.c +++ b/src/hurd_pci.c @@ -304,8 +304,8 @@ pci_device_hurd