Re: [PATCH] Gracefully handle errors using argp_error().

2013-07-08 Thread Samuel Thibault
Cyril Roelandt, le Fri 05 Jul 2013 01:25:26 +0200, a écrit : > I found 4 programs that could be improved by gracefully handling errors > using argp_error: notice (hurd-extras), mboxfs (hurd-extras), tarfs > (incubator) and unionfs. The patches are attached. Applied, thanks! Samuel

Re: [PATCH] Gracefully handle errors using argp_error().

2013-07-05 Thread Justus Winter
Quoting Cyril Roelandt (2013-07-05 10:35:18) > On 07/05/2013 09:33 AM, Justus Winter wrote: > > In your patches the variable state is misspelled sate. How did that > > happen? Your script doesn't seem to include the typo. > > Because the variable is actually named "sate" in the code :) Look at >

Re: [PATCH] Gracefully handle errors using argp_error().

2013-07-05 Thread Cyril Roelandt
On 07/05/2013 09:33 AM, Justus Winter wrote: In your patches the variable state is misspelled sate. How did that happen? Your script doesn't seem to include the typo. Because the variable is actually named "sate" in the code :) Look at mboxfs/mboxfs.c, for instance. Cyril Roelandt.

Re: [PATCH] Gracefully handle errors using argp_error().

2013-07-05 Thread Justus Winter
Hi :), Quoting Cyril Roelandt (2013-07-05 01:25:26) > Hello! > > After seeing this patch from Justus Winter: > > http://lists.gnu.org/archive/html/bug-hurd/2013-06/msg00120.html > > I wrote a Coccinelle script that finds similar errors: Coccinelle is quite awesome :) we should try to find port

[PATCH] Gracefully handle errors using argp_error().

2013-07-04 Thread Cyril Roelandt
Hello! After seeing this patch from Justus Winter: http://lists.gnu.org/archive/html/bug-hurd/2013-06/msg00120.html I wrote a Coccinelle script that finds similar errors: @find_struct@ identifier argp_s; identifier argp_parser_func; identifier options; @@ ( struct argp argp_s = { .par