Re: [PATCH] Fix when enabling APIC without SMP

2022-09-25 Thread Samuel Thibault
Etienne Brateau, le sam. 24 sept. 2022 18:31:45 +0200, a ecrit: > When we want to enable APIC, we must initialize the structure or > otherwise, it will try to access to a not initialized memory addresses. Applied, thanks! > --- > i386/i386/smp.c | 10 ++ > i386/i386at/model_dep.c

Re: [PATCH] Fix when enabling APIC without SMP

2022-09-24 Thread Almudena Garcia
Ok, I understand. I agree with split apic_init and smp init. But I prefer that the apic init calls be in a separated function, instead directly in machine_init() El sáb, 24 sept 2022 a las 20:14, Etienne Brateau (< etienne.brat...@gmail.com>) escribió: > APIC is also useful for MSI/MSI-X (for PCI

Re: [PATCH] Fix when enabling APIC without SMP

2022-09-24 Thread Etienne Brateau
APIC is also useful for MSI/MSI-X (for PCI). So you might want to have APIC without SMP. Le sam. 24 sept. 2022 à 19:39, Almudena Garcia a écrit : > At first question: why do you want to enable APIC without SMP. > In my known, APIC is only useful when there are multiple processors. Even > IOAPIC

Re: [PATCH] Fix when enabling APIC without SMP

2022-09-24 Thread Almudena Garcia
At first question: why do you want to enable APIC without SMP. In my known, APIC is only useful when there are multiple processors. Even IOAPIC has the purpose of distribute IO inputs to multiple processors. +++ b/i386/i386at/model_dep.c @@ -66,6 +66,7 @@ #include #include #include +#include

[PATCH] Fix when enabling APIC without SMP

2022-09-24 Thread Etienne Brateau
When we want to enable APIC, we must initialize the structure or otherwise, it will try to access to a not initialized memory addresses. --- i386/i386/smp.c | 10 ++ i386/i386at/model_dep.c | 10 -- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/i386/i386/