Re: [PATCH] Fix stack corruption in ext2fs server

2012-07-04 Thread Richard Braun
On Wed, Jul 04, 2012 at 07:58:13AM -0300, Samuel Thibault wrote: > Richard Braun, le Wed 04 Jul 2012 08:22:13 +0200, a écrit : > > It's also quite a lot of heap too, and every 5 seconds. We should > > consider increasing the interval between global syncs to reduce the > > impact of this potentially

Re: [PATCH] Fix stack corruption in ext2fs server

2012-07-04 Thread Samuel Thibault
Richard Braun, le Wed 04 Jul 2012 08:22:13 +0200, a écrit : > On Tue, Jul 03, 2012 at 09:13:36PM -0300, Samuel Thibault wrote: > > Richard Braun, le Tue 03 Jul 2012 23:13:26 +0200, a écrit : > > > * ext2fs/inode.c (diskfs_node_iterate): allocate the temporary node > > > table from the heap instead

Re: [PATCH] Fix stack corruption in ext2fs server

2012-07-03 Thread Richard Braun
On Tue, Jul 03, 2012 at 09:13:36PM -0300, Samuel Thibault wrote: > Richard Braun, le Tue 03 Jul 2012 23:13:26 +0200, a écrit : > > * ext2fs/inode.c (diskfs_node_iterate): allocate the temporary node > > table from the heap instead of the stack. > > That can be quite a lot for the stack indeed, tha

Re: [PATCH] Fix stack corruption in ext2fs server

2012-07-03 Thread Samuel Thibault
Richard Braun, le Tue 03 Jul 2012 23:13:26 +0200, a écrit : > * ext2fs/inode.c (diskfs_node_iterate): allocate the temporary node > table from the heap instead of the stack. That can be quite a lot for the stack indeed, thanks! Samuel

[PATCH] Fix stack corruption in ext2fs server

2012-07-03 Thread Richard Braun
* ext2fs/inode.c (diskfs_node_iterate): allocate the temporary node table from the heap instead of the stack. Signed-off-by: Richard Braun --- ext2fs/inode.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/ext2fs/inode.c b/ext2fs/inode.c index f25cc1f..2da8a95