Re: [PATCH] Add ACPI translator and shutdown RPC that turns off pc

2019-03-05 Thread Joshua Branson
Samuel Thibault writes: > Hello, > > We had no reviewing news on this. I ended up just commiting it and added > a few changes (notably trying the Mach method is the Hurd method doesn't > work). I have also uploaded it as Debian package with the required > changes to actually set it up. That's al

Re: [PATCH] Add ACPI translator and shutdown RPC that turns off pc

2019-03-04 Thread Samuel Thibault
Hello, We had no reviewing news on this. I ended up just commiting it and added a few changes (notably trying the Mach method is the Hurd method doesn't work). I have also uploaded it as Debian package with the required changes to actually set it up. Samuel

Re: [PATCH] Add ACPI translator and shutdown RPC that turns off pc

2019-02-02 Thread Samuel Thibault
Samuel Thibault, le sam. 02 févr. 2019 06:40:37 +0100, a ecrit: > Joan Lledó, le sam. 02 févr. 2019 00:29:21 +0100, a ecrit: > > > The Hurd can't be a one-man-reviews-all show, that will just not work. > > > If people don't help me with reviewing code > > > > I don't feel I'm ready for this job >

Re: [PATCH] Add ACPI translator and shutdown RPC that turns off pc

2019-02-01 Thread Samuel Thibault
Joan Lledó, le sam. 02 févr. 2019 00:29:21 +0100, a ecrit: > > The Hurd can't be a one-man-reviews-all show, that will just not work. > > If people don't help me with reviewing code > > I don't feel I'm ready for this job Nobody is ever ready for a given job :) Samuel

Re: [PATCH] Add ACPI translator and shutdown RPC that turns off pc

2019-02-01 Thread Bosco García
I will try to get time to test it and read the code. I think that Hurd is a valuable project that deserves people collaborating on it. I would like to say thanks to Samuel for his great contribution to this project. On Fri, 1 Feb 2019 at 19:03, Samuel Thibault wrote: > Hello, > > On my way to

Re: [PATCH] Add ACPI translator and shutdown RPC that turns off pc

2019-02-01 Thread Joan Lledó
Hi, > The Hurd can't be a one-man-reviews-all show, that will just not work. > If people don't help me with reviewing code I don't feel I'm ready for this job and I suspect that's probably the case for others too. But anyway, is there more code to be reviewed? I could do it when I finish porting

Re: [PATCH] Add ACPI translator and shutdown RPC that turns off pc

2019-02-01 Thread Samuel Thibault
Hello, On my way to FOSDEM, I'm writing my slides, and remember that this ACPI work is still in my inbox, unreviewed. The Hurd can't be a one-man-reviews-all show, that will just not work. If people don't help me with reviewing code, things will go only at the pace I can handle, that is, extremel

Re: [PATCH] Add ACPI translator and shutdown RPC that turns off pc

2018-11-25 Thread Kalle Olavi Niemitalo
Damien Zammit writes: > Surely S5 always has to exist, how else do you power off the machine? There could perhaps be an Else branch with different values.

Re: [PATCH] Add ACPI translator and shutdown RPC that turns off pc

2018-11-25 Thread Damien Zammit
Hi Kalle, On 25/11/18 19:58, Kalle Olavi Niemitalo wrote: > Perhaps this code should first check whether the SCI_EN bit is > already set, as described in ACPI 5.0 section 4.8.2.5 > "Legacy/ACPI Select and the SCI Interrupt", and skip the outb if > so. Section 5.2.9 "Fixed ACPI Description Table (

Re: [PATCH] Add ACPI translator and shutdown RPC that turns off pc

2018-11-25 Thread Kalle Olavi Niemitalo
Damien Zammit writes: > + /* Enable ACPI */ > + outb(acpi_en, smi_cmd); > + for (i = 0; i < 300; i++) > + { > +if ( (inw(pm1a_ctl) & SCI_EN) == SCI_EN) > + break; > + } Perhaps this code should first check whether the SCI_EN bit is already set, as described in ACPI 5.0 section 4.8.

[PATCH] Add ACPI translator and shutdown RPC that turns off pc

2018-11-24 Thread Damien Zammit
Hi all, I have written a new RPC that is called from startup for shutting down the pc. It has been tested on QEMU and successfully powers off the machine causing the qemu window to disappear without manually closing it when you type "halt" as root and it goes through the proper shutdown sequence