Re: [PATCH] About the bug that makes pfinet crash

2008-11-24 Thread Thomas Schwinge
Hello! On Mon, Nov 24, 2008 at 07:51:21PM +0100, Samuel Thibault wrote: > Thomas Schwinge, le Mon 24 Nov 2008 11:43:58 +0100, a écrit : > > > > - if (count == 0 || count > PAGE_SIZE) > > > > + if (count < ifp->if_header_size || > > > > + count > ifp->if_header_size + ifp->if_

Re: [PATCH] About the bug that makes pfinet crash

2008-11-24 Thread Samuel Thibault
Thomas Schwinge, le Mon 24 Nov 2008 11:43:58 +0100, a écrit : > > > - if (count == 0 || count > PAGE_SIZE) > > > + if (count < ifp->if_header_size || > > > + count > ifp->if_header_size + ifp->if_mtu) > > > return D_INVALID_SIZE; > > > > > > assert(copy->type == VM_MAP_COP

Re: [PATCH] About the bug that makes pfinet crash

2008-11-24 Thread Thomas Schwinge
Hello! On Mon, Nov 24, 2008 at 12:06:07AM +0100, Samuel Thibault wrote: > Thomas Schwinge, le Sat 22 Nov 2008 22:54:21 +0100, a écrit : > > > believing > > > that the IP stack wouldn't overcome the typical 1500B MTU anyway. > > > > It will, because you told it can do so, allowing for a PAGE_SIZE

Re: [PATCH] About the bug that makes pfinet crash

2008-11-23 Thread Samuel Thibault
Thomas Schwinge, le Sat 22 Nov 2008 22:54:21 +0100, a écrit : > > believing > > that the IP stack wouldn't overcome the typical 1500B MTU anyway. > > It will, because you told it can do so, allowing for a PAGE_SIZE MTU. > But: The MTU is defined to be without the ethernet headers, thus pfinet > ca

[PATCH] About the bug that makes pfinet crash

2008-11-22 Thread Thomas Schwinge
Hello! On Fri, Nov 21, 2008 at 12:50:42AM +0100, Samuel Thibault wrote: > Thomas Schwinge, le Fri 21 Nov 2008 00:08:32 +0100, a écrit : > > Further printf inspection revealed that skb->len / count was 4110 > > (reproducibly). > > Ah. That's more than a page, it _can_ be implemented in xen by usin