Re: [PATCH] 1(3) hurd+glibc: Support for file record locking

2019-10-29 Thread Samuel Thibault
Hello, Svante Signell, le jeu. 12 sept. 2019 10:15:27 +0200, a ecrit: > Attached is the first part of the patches for file record locking: Now (at last!) applied, thanks a lot! Samuel

Re: [PATCH] 1(3) hurd+glibc: Support for file record locking

2019-10-29 Thread Svante Signell
On Mon, 2019-10-28 at 01:40 +0100, Samuel Thibault wrote: > There was an issue with rlock-tweak.c, revealed by the tdb testsuite: > > Index: hurd-debian/libfshelp/rlock-tweak.c > === > --- hurd-debian.orig/libfshelp/rlock-tweak.c > ++

Re: [PATCH] 1(3) hurd+glibc: Support for file record locking

2019-10-27 Thread Samuel Thibault
There was an issue with rlock-tweak.c, revealed by the tdb testsuite: Index: hurd-debian/libfshelp/rlock-tweak.c === --- hurd-debian.orig/libfshelp/rlock-tweak.c +++ hurd-debian/libfshelp/rlock-tweak.c @@ -312,10 +312,8 @@ fshelp_rloc

Re: [PATCH] 1(3) hurd+glibc: Support for file record locking

2019-10-27 Thread Samuel Thibault
Hello, Thanks for your work! It looks in good shape, I'll do some tests and probably commit. General note: do not include unrelated changes. Copyright text update belongs to separate patches. Dropping useless inclusions as well. Anything else than what is at stake makes the review longer, so you

[PATCH] 1(3) hurd+glibc: Support for file record locking

2019-09-12 Thread Svante Signell
Hello, Attached is the first part of the patches for file record locking: libfshelp_rlock.patch libdiskfs_file_record_lock.patch libtrivfs_file_record_lock.patch The second part is following in a subsequent email: libnetfs_file_record_lock.patch pflocal_fs.c.patch hurd_add_RPC.patch The third pa

Re: [PATCH] 1(3) hurd+glibc: Support for file record locking

2019-02-03 Thread Samuel Thibault
Hello, Svante Signell, le dim. 03 févr. 2019 13:31:11 +0100, a ecrit: > GNU/Linux and GNU/Hurd: (all OK) > Terminal 1 and Terminal 2: > ./test-flock foo r x > ./test-flock foo w x > ./test-flock foo r xn > ./test-flock foo w xn Ok. One remaining question is whether we want to let flock work even

Re: [PATCH] 1(3) hurd+glibc: Support for file record locking

2019-02-03 Thread Svante Signell
On Sat, 2019-02-02 at 14:34 +0100, Samuel Thibault wrote: > Hello, > So can you confirm my guesswork above? If, so, then only keep the first > line (the second line doesn't make sense in my guesswork), and mention > that while fcntl requires WR access for exclusive lock, flock doesn't. I've now r

Re: [PATCH] 1(3) hurd+glibc: Support for file record locking

2019-02-02 Thread Svante Signell
On Sat, 2019-02-02 at 14:34 +0100, Samuel Thibault wrote: > Hello, > > Thanks for the fixes! YW! > Svante Signell, le sam. 02 févr. 2019 11:52:56 +0100, a ecrit: > > On Sun, 2018-12-30 at 21:21 +0100, Samuel Thibault wrote: > > > Svante Signell, le sam. 22 déc. 2018 13:07:37 +0100, a ecrit: > >

Re: [PATCH] 1(3) hurd+glibc: Support for file record locking

2019-02-02 Thread Samuel Thibault
Hello, Thanks for the fixes! Svante Signell, le sam. 02 févr. 2019 11:52:56 +0100, a ecrit: > On Sun, 2018-12-30 at 21:21 +0100, Samuel Thibault wrote: > > Svante Signell, le sam. 22 déc. 2018 13:07:37 +0100, a ecrit: > > > diskfs_S_file_lock (struct protid *cred, int flags) > > > { > > ... > >

[PATCH] 1(3) hurd+glibc: Support for file record locking

2019-02-02 Thread Svante Signell
Hello, Attached is the first part of the patches for file record locking: libfshelp_rlock.patch libdiskfs_file_record_lock.patch libtrivfs_file_record_lock.patch The second part is following in a subsequent email: libnetfs_file_record_lock.patch pflocal_fs.c.patch hurd_add_RPC.patch The third pa

Re: [PATCH] 1(3) hurd+glibc: Support for file record locking

2018-12-30 Thread Samuel Thibault
Hello, Svante Signell, le sam. 22 déc. 2018 13:07:37 +0100, a ecrit: > diskfs_S_file_lock (struct protid *cred, int flags) > { ... > + /* XXX: Fix for flock(2) calling fcntl(2) */ > + if ((openstat & O_RDONLY) && !(openstat & O_WRONLY)) openstat |= O_WRONLY; > + if (!(openstat & O_RDONLY) &&

[PATCH] 1(3) hurd+glibc: Support for file record locking

2018-12-22 Thread Svante Signell
Hello, Attached is the first part of the patches for file record locking: libfshelp_rlock.patch libdiskfs_file_record_lock.patch libtrivfs_file_record_lock.patch The second part is following in a subsequent email: libnetfs_file_record_lock.patch pflocal_fs.c.patch hurd_add_RPC.patch The third pa