Re: [PATCH] Fix some compiler warnings

2023-01-18 Thread Samuel Thibault
Applied, thanks! Svante Signell, le mer. 18 janv. 2023 13:29:48 +0100, a ecrit: > On Wed, 2023-01-18 at 12:27 +0100, Samuel Thibault wrote: > > Svante Signell, le mer. 18 janv. 2023 11:59:40 +0100, a ecrit: > > > On Wed, 2023-01-18 at 02:02 +0100, Samuel Thibault wrote: > > > > Hello, > > > > > >

Re: [PATCH] Fix some compiler warnings

2023-01-18 Thread Svante Signell
On Wed, 2023-01-18 at 12:27 +0100, Samuel Thibault wrote: > Svante Signell, le mer. 18 janv. 2023 11:59:40 +0100, a ecrit: > > On Wed, 2023-01-18 at 02:02 +0100, Samuel Thibault wrote: > > > Hello, > > > > > > > > > But conversely when we'll build it in 64bit, vm_page_size > > > (actually uintptr

Re: [PATCH] Fix some compiler warnings

2023-01-18 Thread Samuel Thibault
Svante Signell, le mer. 18 janv. 2023 11:59:40 +0100, a ecrit: > On Wed, 2023-01-18 at 02:02 +0100, Samuel Thibault wrote: > > Hello, > > > > > > But conversely when we'll build it in 64bit, vm_page_size (actually > > uintptr_t) will be an unsigned long. > > > > This needs to be fixed the *prope

Re: [PATCH] Fix some compiler warnings

2023-01-18 Thread Svante Signell
On Wed, 2023-01-18 at 02:02 +0100, Samuel Thibault wrote: > Hello, > > > But conversely when we'll build it in 64bit, vm_page_size (actually > uintptr_t) will be an unsigned long. > > This needs to be fixed the *proper* way: either use the PRIuPTR > macro, or cast the value into unsigned long.

Re: [PATCH] Fix some compiler warnings

2023-01-17 Thread Samuel Thibault
Hello, Svante Signell, le mar. 17 janv. 2023 13:15:27 +0100, a ecrit: > --- hurd-git/ext2fs/ext2fs.c 2022-12-08 15:05:29.80800 +0100 > +++ hurd-git/ext2fs/ext2fs.c 2022-12-08 19:11:12.60400 +0100 > @@ -232,7 +232,7 @@ >if (store->size < SBLOCK_OFFS + SBLOCK_SIZE) > ext2_panic ("

[PATCH] Fix some compiler warnings

2023-01-17 Thread Svante Signell
Hi, The attached patch fixes some format warnings as well as an implicit declaration of ‘startup_essential_task’ in mach-defpager/main.c. Applies nicely to hurd-0.9.git20221224 and latest git. Thanks! --- hurd-git/ext2fs/ext2fs.c 2022-12-08 15:05:29.80800 +0100 +++ hurd-git/ext2fs/ext2fs.c 2

Re: [PATCH] fix some compiler warnings in gnumach

2016-01-01 Thread Samuel Thibault
Hello, Flavio Cruz, on Thu 31 Dec 2015 19:08:19 +0100, wrote: > @@ -1666,7 +1666,7 @@ device_get_status (void *d, dev_flavor_t flavor, > dev_status_t status, > return D_INVALID_OPERATION; >else > { > - struct disk_parms *dp = status; > + struct disk_parms *dp = (st

[PATCH] fix some compiler warnings in gnumach

2015-12-31 Thread Flavio Cruz
Fix some compiler warnings. * linux/dev/glue/block.c (out): Cast to device_t. * linux/dev/glue/block.c (device_get_status): Cast to struct disk_params *. * linux/dev/init/main.c (alloc_contig_mem): Initialize addr and cast return value to void *. * i386/i386/phys.c (pmap_copy_page): Initialize sr