Re: [PATCH] Hurd port: update interface to match upstream and fix warnings.

2024-06-25 Thread Simon Marchi
On 2024-06-25 10:26, Flávio Cruz wrote: > Hi Simon > > On Wed, Feb 7, 2024 at 5:01 PM Samuel Thibault <mailto:samuel.thiba...@gnu.org>> wrote: > > Simon Marchi, le mer. 07 févr. 2024 11:47:30 -0500, a ecrit: > > On 2/7/24 01:53, Flavio Cruz wrote: >

Re: [PATCH] Hurd port: update interface to match upstream and fix warnings.

2024-02-07 Thread Simon Marchi
x86_64. > > [1] > https://git.savannah.gnu.org/cgit/hurd/gnumach.git/tree/include/mach/exc.defs I take it that you are not too concerned with backwards compatibility with previous versions of Hurd (compiling new GDBs on old Hurds)? If so, this is fine with me. Approved-By: Simon Marchi Simon

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS OFF TOPIC PRAISE

2020-12-23 Thread Simon Marchi
On 2020-12-23 12:01 p.m., Samuel Thibault wrote: > Hello, > > Simon Marchi, le mar. 22 déc. 2020 22:02:40 -0500, a ecrit: >> I've been told you now have push access, give it a try. > > Yep it worked, thanks! > > Samuel > Nice! Please also commit

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS OFF TOPIC PRAISE

2020-12-22 Thread Simon Marchi
On 2020-12-22 7:39 p.m., Samuel Thibault wrote: > Simon Marchi, le mar. 22 déc. 2020 19:09:17 -0500, a ecrit: >> Samuel, would you like to have push access for GDB? > > That could make things simpler, yes. > >> Do you already have a Sourceware account? >

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS OFF TOPIC PRAISE

2020-12-22 Thread Simon Marchi
On 2020-12-22 6:24 p.m., Joshua Branson wrote: > > I vote we give Samuel commit access! His genius deserves to be > recognized. All in favor, say aye! Sure. Samuel, would you like to have push access for GDB? Do you already have a Sourceware account? Simon

Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS

2020-12-21 Thread Simon Marchi
On 2020-12-21 12:59 p.m., Samuel Thibault via Gdb-patches wrote: > gnu-nat.c was getting the inclusion of vm_param.h only by luck. We > need to explicitly include it to be sure to get the definitions of > VM_MIN/MAX_ADDRESS. > > gdb/ChangeLog: > > * gnu-nat.c: Include . > > diff --git

Re: [PATCH] hurd: Add shared mig declarations

2020-05-31 Thread Simon Marchi
On 2020-05-31 3:20 a.m., Samuel Thibault wrote: > Simon Marchi, le sam. 30 mai 2020 21:51:35 -0400, a ecrit: >> On 2020-05-30 2:23 p.m., Samuel Thibault wrote: >>> Fixes >>> >>> exc_request_S.c:177:24: error: no previous declaration for ‘exc_server’ >>

Re: [PATCH] hurd: Add shared mig declarations

2020-05-30 Thread Simon Marchi
On 2020-05-30 2:23 p.m., Samuel Thibault wrote: > Fixes > > exc_request_S.c:177:24: error: no previous declaration for ‘exc_server’ > [-Werror=missing-declarations] > 177 | mig_external boolean_t exc_server > > gdb/ChangeLog: > > * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Ad

Re: [PATCH] gnu-nat: Move local functions inside gnu_nat_target class

2020-05-30 Thread Simon Marchi
On 2020-05-30 2:04 p.m., Samuel Thibault wrote: > This allows to have the process_stratum_target object at hand for future use > in > the gdb API, and only use gnu_target from external calls. > > gdb/Changelog: > > * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced, > steal

Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type

2020-05-30 Thread Simon Marchi
On 2020-05-30 12:53, Samuel Thibault wrote: Simon Marchi, le sam. 30 mai 2020 12:12:24 -0400, a ecrit: We can either push on your behalf. But if you'd like to have push access, because you plan to make regular contributions, you can ask for an account here, and specify me as "ema

Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type

2020-05-30 Thread Simon Marchi
On 2020-05-30 12:00 p.m., Samuel Thibault wrote: > Simon Marchi, le sam. 30 mai 2020 10:39:19 -0400, a ecrit: >> On 2020-05-29 6:00 p.m., Samuel Thibault wrote: >>> Fixes >>> >>> ../../gdb/gnu-nat.c:96:6: error: conflicting declaration ‘bool >>> gn

Re: [PATCHv2 6/7] hurd: add gnu_target pointer to fix thread API calls

2020-05-30 Thread Simon Marchi
On 2020-05-30 11:53 a.m., Samuel Thibault wrote: > Simon Marchi, le sam. 30 mai 2020 10:57:42 -0400, a ecrit: >>> @@ -1106,12 +1109,12 @@ inf_validate_procs (struct inf *inf) >>> if (inferior_ptid == ptid_t (inf->pid)) >>> /* This is the firs

Re: [PATCHv2 3/7] hurd: make function cast stronger

2020-05-30 Thread Simon Marchi
On 2020-05-30 11:32 a.m., Samuel Thibault wrote: > Simon Marchi, le sam. 30 mai 2020 10:47:50 -0400, a ecrit: >> On 2020-05-29 6:01 p.m., Samuel Thibault wrote: >>> process_reply_S.c:104:23: error: function called through a non-compatible >>> type [-Werror] >

Re: [PATCH] hurd: unwinding support over signal trampolines

2020-05-30 Thread Simon Marchi
On 2020-05-29 7:00 p.m., Samuel Thibault wrote: > gdb/ChangeLog: > > 2020-05-29 Samuel Thibault > > * i386-gnu-tdep.c: Include "gdbcore.h" > (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays. > (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL, > I386_GNU_SIGCONTEXT_THREAD

Re: [PATCHv2 7/7] hurd: fix pushing target on inferior creation

2020-05-30 Thread Simon Marchi
On 2020-05-29 6:04 p.m., Samuel Thibault wrote: > This fixes creating inferiors, which was broken since 5b6d1e4fa > ('Multi-target support') > > gdb/ChangeLog: > > 2020-05-29 Samuel Thibault > > * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call > before fork_in

Re: [PATCHv2 6/7] hurd: add gnu_target pointer to fix thread API calls

2020-05-30 Thread Simon Marchi
On 2020-05-29 6:03 p.m., Samuel Thibault wrote: > Fixes > > ../../gdb/gnu-nat.c:1110:28: error: cannot convert ‘ptid_t’ to > ‘process_stratum_target*’ > 1110 |thread_change_ptid (inferior_ptid, ptid); > > and others related to 5b6d1e4fa ("Multi-target support") > > gdb/ChangeLog: > >

Re: [PATCHv2 5/7] hurd: remove unused variables

2020-05-30 Thread Simon Marchi
On 2020-05-29 6:03 p.m., Samuel Thibault wrote: > Fixes > > ../../gdb/gnu-nat.c:2554:7: error: unused variable ‘res’ > [-Werror=unused-variable] > 2554 | int res; > ../../gdb/gnu-nat.c:2644:20: error: unused variable ‘old_address’ > [-Werror=unused-variable] > 2644 | vm_address_t old_a

Re: [PATCHv2 4/7] hurd: add missing include

2020-05-30 Thread Simon Marchi
On 2020-05-29 6:02 p.m., Samuel Thibault wrote: > Fixes > > ../../gdb/gnu-nat.c:2522:14: error: ‘target_gdbarch’ was not declared in this > scope; did you mean ‘target_detach’? > 2522 |paddress (target_gdbarch (), memaddr), pulongest (len), > > gdb/Changelog: > > 2020-05-29 Samuel Thibaul

Re: [PATCHv2 3/7] hurd: make function cast stronger

2020-05-30 Thread Simon Marchi
On 2020-05-29 6:01 p.m., Samuel Thibault wrote: > Fixes > > process_reply_S.c:104:23: error: function called through a non-compatible > type [-Werror] > 104 | OutP->RetCode = (*(kern_return_t (*)(mach_port_t, > kern_return_t)) S_proc_setmsgport_reply) (In0P->Head.msgh_request_port, In0P-

Re: [PATCHv2 2/7] hurd: add missing awk script dependency

2020-05-30 Thread Simon Marchi
On 2020-05-29 6:01 p.m., Samuel Thibault wrote: > gdb/ChangeLog: > > 2020-05-29 Samuel Thibault > > * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on > $(srcdir)/reply_mig_hack.awk. > > diff --git a/gdb/config/i386/i386gnu.mn b/gdb/config/i386/i386gnu.mn > index 1c3453823d

Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type

2020-05-30 Thread Simon Marchi
On 2020-05-29 6:00 p.m., Samuel Thibault wrote: > Fixes > > ../../gdb/gnu-nat.c:96:6: error: conflicting declaration ‘bool gnu_debug_flag’ >96 | bool gnu_debug_flag = false; > ../../gdb/gnu-nat.c: In function ‘void _initialize_gnu_nat()’: > ../../gdb/gnu-nat.c:3511:7: error: cannot > > gdb/Ch

Re: [PATCH 1/5] hurd: fix gnu_debug_flag type

2020-05-29 Thread Simon Marchi
On 2020-05-29 4:01 p.m., Samuel Thibault wrote: > gdb/ChangeLog: > > 2020-05-29 Samuel Thibault > > * gdb/gnu-nat.h (gnu_debug_flag): Set type to bool. > > diff --git a/gdb/gnu-nat.h b/gdb/gnu-nat.h > index 77c57817b2..7c36778394 100644 > --- a/gdb/gnu-nat.h > +++ b/gdb/gnu-nat.h > @@

Re: [PATCH] hurd: add missing include

2020-05-29 Thread Simon Marchi
On 2020-05-29 4:10 p.m., Samuel Thibault wrote: > gdb/Changelog: > > 2020-05-29 Samuel Thibault > > * gnu-nat.c: Include "gdbarch.h". > > diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c > index 3b438a9a43..78e9ab7f71 100644 > --- a/gdb/gnu-nat.c > +++ b/gdb/gnu-nat.c > @@ -64,6 +64,7 @@ exte

Re: [PATCH] hurd: Add enough auxv support for AT_ENTRY for PIE binaries

2017-12-28 Thread Simon Marchi
On 2017-12-27 10:41 AM, Samuel Thibault wrote: > gdb/ChangeLog: > > * gdb/gnu-nat.c: Include and . > (gnu_xfer_auxv): New function. > (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is > TARGET_OBJECT_AUXV. > --- > gdb/ChangeLog | 7 +++ > gdb/gnu-nat.c | 58 +++

Re: hurd: PIE support

2017-12-27 Thread Simon Marchi
On 2017-12-27 10:44 AM, Samuel Thibault wrote: > Hello, > > Simon Marchi, on mar. 26 déc. 2017 21:48:23 -0500, wrote: >> We would also need a ChangeLog entry. > > Well, I had put a ChangeLog entry at the top of the posted file. Is > something else needed? In the patch

Re: hurd: PIE support

2017-12-27 Thread Simon Marchi
On 2017-12-22 11:55 AM, Samuel Thibault wrote: > Hello, > > PIE is being pushed more and more, so we have to support it in the Hurd > port :) > > The simplest way to fix things is to provide gdb with the entry address > through auxv. The attached patch implements this. Could you have a look > soo

Re: [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs

2016-12-08 Thread Simon Marchi
On 2016-12-08 07:01, Thomas Schwinge wrote: On GNU/Hurd, there is no "#define PATH_MAX", so this fails to build. (I'm aware that there is other PATH_MAX usage in GDB sources, which we ought to fix at some point, for example in gdbserver -- which is not yet enabled for GNU/Hurd.) Unless I miss

Re: [PATCH v3 4/7] Per-inferior/Inferior-qualified thread IDs

2016-12-07 Thread Simon Marchi
gt; --- gdb/ChangeLog > +++ gdb/ChangeLog > @@ -1,3 +1,8 @@ > +2016-12-07 Thomas Schwinge > + > + * gnu-nat.c (set_sig_thread_cmd): Call global_thread_id_to_ptid > + instead of thread_id_to_pid. > + > 2016-12-06 Simon Marchi > > * inferior.c (inferior_comman