Re: [PATCHSET] some random Hurd patches

On Wed, Sep 07, 2011 at 05:24:55PM +0200, Thomas Schwinge wrote: > Hi! > > On Mon, 15 Aug 2011 14:31:46 +0200, Jonathan Neuschäfer > wrote: > > In reply to this mail, I'll send some patches. (They are untested) > > Thanks anyway! ;-) (But of course, we prefer test

Re: [PATCH v2 2/4] fix a realloc-related memory leak in localhost()

On Wed, Sep 07, 2011 at 05:19:12PM +0200, Thomas Schwinge wrote: > Hi! > > On Mon, 15 Aug 2011 22:10:07 +0200, Jonathan Neuschäfer > wrote: > > * libshouldbeinlibc/localhost.c (localhost): assign the return value > >of realloc to a temporary variable to avoid

Re: [PATCH v2 1/4] ftpfs/host.c: use NULL (instead of 0) for pointers

ht NULL would be clearer in some way. Thanks, Jonathan Neuschäfer

[PATCH v2 2/4] fix a realloc-related memory leak in localhost()

* libshouldbeinlibc/localhost.c (localhost): assign the return value of realloc to a temporary variable to avoid losing the old value of buf in the case of realloc failing. --- libshouldbeinlibc/localhost.c | 21 ++--- 1 files changed, 14 insertions(+), 7 deletions(-) dif

[PATCH v2 1/4] ftpfs/host.c: use NULL (instead of 0) for pointers

* ftpfs/host.c (split_server_name): assign NULL to *host, *user, and *passwd instead of 0. --- ftpfs/host.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ftpfs/host.c b/ftpfs/host.c index cd6fd4c..71cf6c8 100644 --- a/ftpfs/host.c +++ b/ftpfs/host.c @@ -32,9 +32

[PATCH v2 3/4] pfinet/linux-src: fix a memory leak

* pfinet/linux-src/net/ipv4/ip_options.c (ip_options_get): calculate the size of opt only once, free opt before returning -EFAULT. --- pfinet/linux-src/net/ipv4/ip_options.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/pfinet/linux-src/net/ipv4/ip_options.c

[PATCH 3/4] pfinet/linux-src: fix a memory leak

Also a tiny bit of cleanup. --- pfinet/linux-src/net/ipv4/ip_options.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/pfinet/linux-src/net/ipv4/ip_options.c b/pfinet/linux-src/net/ipv4/ip_options.c index a3d1f0a..ec21054 100644 --- a/pfinet/linux-src/net/ipv4/ip_

[PATCH 1/4] ftpfs/host.c: use NULL (instead of 0) for pointers

--- ftpfs/host.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ftpfs/host.c b/ftpfs/host.c index cd6fd4c..71cf6c8 100644 --- a/ftpfs/host.c +++ b/ftpfs/host.c @@ -32,9 +32,9 @@ split_server_name (const char *server, char **host, char **user, char **passwd) size_

[PATCH 2/4] fix a realloc-related memory leak in localhost()

I don't really like this patch, but feel free to apply it, if you do. --- libshouldbeinlibc/localhost.c | 21 ++--- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/libshouldbeinlibc/localhost.c b/libshouldbeinlibc/localhost.c index f0c6754..f21f970 100644 --- a/li

[PATCHSET] some random Hurd patches

Hello. In reply to this mail, I'll send some patches. (They are untested) I also planned to send a coccinelle-generated patch, but I didn't review it, so it would be a bit pointless. Anyway, this is the coccinelle patch: @@ expression *p; @@ - p = 0 + p = NULL Thanks,