Re: [PATCH] The function lock_info_sort was defined as static and aliased via a macro to lis, requiring a forward declaration to be callable from lip(). This indirection served no functional purpose a

2025-06-21 Thread Milos Nikic
Thank you. I wasn't aware of that. Will try to format it better going forward! On Sat, Jun 21, 2025, 4:43 AM Samuel Thibault wrote: > Hello, > > Milos Nikic, le ven. 20 juin 2025 18:14:58 +0100, a ecrit: > > This change: > > - Removes the macro aliasing lock_info_sort to lis > > - Moves lock_i

Fwd: Re: [PATCH 0/1] fix cp /dev/null file

2025-06-21 Thread Guy-Fleury Iteriteka
Courriel initial De : gfleury Envoyé : 21 juin 2025 13:23:17 GMT+02:00 À : Samuel Thibault Objet : Re: [PATCH 0/1] fix cp /dev/null file Le 2025-01-18 18:35, Guy-Fleury Iteriteka a écrit : > Le 18 janvier 2025 15:08:55 GMT+02:00, Samuel Thibault > a écrit : Guy-Fleury It

Re: [PATCH] Reading lapic->error_status.r may have side effects, and we must preserve it. To avoid a compiler warning about err being unused, cast it to (void).

2025-06-21 Thread Samuel Thibault
Milos Nikic, le jeu. 19 juin 2025 16:51:05 +0100, a ecrit: > This keeps the behavior intact while eliminating the warning. Applied, thanks! > --- > i386/i386/smp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/i386/i386/smp.c b/i386/i386/smp.c > index e3e4cc82..53d9b876 100644 > --

Re: Problem without -M q35 option for qemu

2025-06-21 Thread Almudena Garcia
Hi: We get the same issue (or pretty similar) in real hardware, in many Thinkpad models with Core2Duo. And the already known problem with SMP even in more modern Thinkpad models (probably the problem keeps in some other computers, but I don't have another PC to test it). I think that the problem

Re: [PATCH] Fixing compiler warnings on ktss c-file. Some that only appear when building on 32 bit arch, some that happen regardless of architecture. Changes tested on the 32 bit build.

2025-06-21 Thread Samuel Thibault
Applied, thanks! Milos Nikic, le ven. 20 juin 2025 22:23:43 +0100, a ecrit: > --- > i386/i386/ktss.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/i386/i386/ktss.c b/i386/i386/ktss.c > index 34cb6df2..1f61d3d6 100644 > --- a/i386/i386/ktss.c > +++ b/i386/i386/ktss.

Re: [PATCH] The function lock_info_sort was defined as static and aliased via a macro to lis, requiring a forward declaration to be callable from lip(). This indirection served no functional purpose a

2025-06-21 Thread Samuel Thibault
Hello, Milos Nikic, le ven. 20 juin 2025 18:14:58 +0100, a ecrit: > This change: > - Removes the macro aliasing lock_info_sort to lis > - Moves lock_info_sort before lip() to eliminate the need for a forward > declaration > - Updates the call in lip() to refer to lock_info_sort directly > > The