Re: [PATCH] configfrag: fix usage of mach_ncpus before his definition

2024-11-19 Thread Samuel Thibault
Applied, thanks! Etienne Brateau, le mar. 19 nov. 2024 20:10:48 +0100, a ecrit: > --- > configfrag-first.ac | 11 +++ > configfrag.ac | 11 --- > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/configfrag-first.ac b/configfrag-first.ac > index 5dc0db2c..

[PATCH] configfrag: fix usage of mach_ncpus before his definition

2024-11-19 Thread Etienne Brateau
--- configfrag-first.ac | 11 +++ configfrag.ac | 11 --- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/configfrag-first.ac b/configfrag-first.ac index 5dc0db2c..22e34af8 100644 --- a/configfrag-first.ac +++ b/configfrag-first.ac @@ -23,6 +23,17 @@ nlpr=0

Re: [RFC PATCH] Add rtc server, rtc-read and rtc-set operations

2024-11-19 Thread Samuel Thibault
Sergey Bugaev, le mar. 19 nov. 2024 13:21:47 +0300, a ecrit: > On Tue, Nov 19, 2024 at 12:08 PM Samuel Thibault > wrote: > > Ah, yes. Since it's not a performance-critical service, you can as well > > use ports_manage_port_operations_one_thread instead, and get done with > > it :) > > This might

Re: [RFC PATCH] Add rtc server, rtc-read and rtc-set operations

2024-11-19 Thread Sergey Bugaev
On Tue, Nov 19, 2024 at 12:08 PM Samuel Thibault wrote: > Ah, yes. Since it's not a performance-critical service, you can as well > use ports_manage_port_operations_one_thread instead, and get done with > it :) This might be an issue once we implement the blocking read/select functionality; don't

Re: [RFC PATCH] Add rtc server, rtc-read and rtc-set operations

2024-11-19 Thread Zhaoming Luo
On 11/19/24 5:08 PM, Samuel Thibault wrote: Zhaoming Luo, le mar. 19 nov. 2024 16:54:38 +0800, a ecrit: On 11/17/24 9:04 PM, Sergey Bugaev wrote: I don't think I need to do anything before exit. However, maybe I need to ensure the rtc operations is thread-safe; I haven't done it. Ah, yes. Sinc

Re: [RFC PATCH] Add rtc server, rtc-read and rtc-set operations

2024-11-19 Thread Samuel Thibault
Zhaoming Luo, le mar. 19 nov. 2024 16:54:38 +0800, a ecrit: > On 11/17/24 9:04 PM, Sergey Bugaev wrote: > I don't think I need to do anything before exit. However, maybe I need to > ensure the rtc operations is thread-safe; I haven't done it. Ah, yes. Since it's not a performance-critical service,

Re: [RFC PATCH] Add rtc server, rtc-read and rtc-set operations

2024-11-19 Thread Zhaoming Luo
First of all, thanks for the code review. On 11/17/24 9:04 PM, Sergey Bugaev wrote: On Sun, Nov 17, 2024 at 3:34 PM Zhaoming Luo wrote: diff --git a/hurd/rtc.h b/hurd/rtc.h new file mode 100644 index ..6516e86c --- /dev/null +++ b/hurd/rtc.h +struct rtc_time { + int tm_sec; + int