Re: [PATCH] maint: Add empty "check" target.

2023-06-21 Thread Samuel Thibault
Janneke Nieuwenhuizen, le mer. 21 juin 2023 22:31:27 +0200, a ecrit: > Don't you think "we" (;-) should also work to have at least a somewhat > sensible check target for the Hurd, eventually? Sure :) There are actually already some tests available. They "just" need some infrastructure to start tr

Re: [PATCH] maint: Add empty "check" target.

2023-06-21 Thread Janneke Nieuwenhuizen
Samuel Thibault writes: > Samuel Thibault, le mer. 21 juin 2023 00:10:37 +0200, a ecrit: >> Janneke Nieuwenhuizen, le mar. 20 juin 2023 18:07:06 +0200, a ecrit: >> > Provide a "check" target like any GNU package, as is advertised in >> > INSTALL. >> >> Well, I'd say that if doesn't make anything,

Re: [PATCH] maint: Add empty "check" target.

2023-06-21 Thread Janneke Nieuwenhuizen
Samuel Thibault writes: Hi Samuel, > Janneke Nieuwenhuizen, le mar. 20 juin 2023 18:07:06 +0200, a ecrit: >> Provide a "check" target like any GNU package, as is advertised in >> INSTALL. > > Well, I'd say that if doesn't make anything, better just drop the > mention of it from INSTALL. Hmm. Wh

Re: [PATCH] proc: Fix pointer truncation in get_string_array

2023-06-21 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 21 juin 2023 13:56:38 +0300, a ecrit: > Due to little-endianness of x86, this resulted in a 64-bit pointers that > pointed to the lower 4 GB of the address space being treated as a 32-bit > pointer followed by NULL, which manifested as only the first program

[PATCH] proc: Fix pointer truncation in get_string_array

2023-06-21 Thread Sergey Bugaev
Due to little-endianness of x86, this resulted in a 64-bit pointers that pointed to the lower 4 GB of the address space being treated as a 32-bit pointer followed by NULL, which manifested as only the first program arg (the argv[0]) being visible in ps output. When a pointer pointed outside of the