Re: [PATCH v3 2/2] Use O_IGNORE_CTTY where appropriate

2023-06-05 Thread Paul Eggert
On 2023-06-04 13:42, Sergey Bugaev via Libc-alpha wrote: - int flags = O_RDONLY | O_NONBLOCK | O_DIRECTORY | O_CLOEXEC; + int flags = O_RDONLY | O_NONBLOCK | O_DIRECTORY | O_CLOEXEC | O_IGNORE_CTTY; Why is O_IGNORE_CTTY useful here? O_DIRECTORY means that the file cannot be a tty. (If GNU/Hu

Re: [PATCH v3 1/2] include/fcntl.h: Define O_IGNORE_CTTY

2023-06-05 Thread Adhemerval Zanella Netto
On 04/06/23 17:42, Sergey Bugaev via Libc-alpha wrote: > This internal definition makes it possible to use O_IGNORE_CTTY in > the glibc codebase unconditionally, no matter whether the current port > provides it or not (i.e. both on Hurd and on Linux). Along with the > definition, this adds a sma

Re: [PATCH gnumach] Update the 64bit RPC ABI to be simpler

2023-06-05 Thread Luca
Hi, Il 17/05/23 05:03, Flavio Cruz ha scritto: * Make full use of the 8 bytes available in mach_msg_type_t by moving into the unused 4 bytes. This allows us to use 32bits for mach_msg_type_number_t whether we use the longform or not. * Make mach_msg_type_long_t exactly the same as mach_msg

Re: 64bit startup

2023-06-05 Thread Sergey Bugaev
On Mon, Jun 5, 2023 at 2:05 PM Samuel Thibault wrote: > I can easily trigger crashes with > > fsysopts / --writable > while true ; do ps-hurd -feMj > /tmp/blip ; done That is going to be much easier to debug than debootstrap, thank you! Sergey

Re: [PATCH v3 2/2] Use O_IGNORE_CTTY where appropriate

2023-06-05 Thread Sergey Bugaev
Hello, On Mon, Jun 5, 2023 at 12:28 PM Florian Weimer wrote: > > * shm_open, sem_open: These don't work with ttys > > * opendir: Directories are unlikely to be ttys > > I scrolled through the patch, and it seems to me that all these open > calls could use O_NOCTTY. Perhaps they could use O_NOCTT

Re: 64bit startup

2023-06-05 Thread Samuel Thibault
Samuel Thibault, le dim. 04 juin 2023 19:46:25 +0200, a ecrit: > Sergey Bugaev, le dim. 04 juin 2023 20:40:54 +0300, a ecrit: > > On Sun, Jun 4, 2023 at 8:21 PM Samuel Thibault > > wrote: > > > It seems so indeed. But it's not only the stack guard, but various TLS > > > accesses. > > > > What wo

Re: [PATCH v3 2/2] Use O_IGNORE_CTTY where appropriate

2023-06-05 Thread Florian Weimer
* Sergey Bugaev: > * getpt, openpty: Opening an unused pty, which can't be our ctty Please add this as a comment to the open operation. > * shm_open, sem_open: These don't work with ttys > * opendir: Directories are unlikely to be ttys I scrolled through the patch, and it seems to me that all t