Re: [PATCH 4/4] Add cpu_number and cpuboot

2023-01-23 Thread Samuel Thibault
Flávio Cruz, le mar. 24 janv. 2023 01:15:15 -0500, a ecrit: > +       int kernel_id; > +       unsigned long flags; > + > +       cpu_intr_save(&flags); > + > +       kernel_id = apic_get_cpu_kernel_id(apic_get_current_cpu()); > + > +       cpu_intr_restore(flags); >

[PATCH] Fix several warnings for -Wmissing-prototypes (part 2)

2023-01-23 Thread Flavio Cruz
* i386/i386/io_map.c: code is unused. * i386/i386/io_perm.c: include mig prototypes. * i386/i386/mp_desc.c: Deleted interrupt_stack_alloc since it is not used. * i386/i386/seg.h: Moved descriptor structs to i386/include/mach/i386/mach_i386_types.h as that represents the interface types for RPC

Re: [PATCH 4/4] Add cpu_number and cpuboot

2023-01-23 Thread Flávio Cruz
Hi Damien On Sat, Jan 21, 2023 at 3:05 AM Damien Zammit wrote: > --- > i386/i386/cpu_number.c | 37 ++ > i386/i386/cpuboot.S| 164 + > 2 files changed, 201 insertions(+) > create mode 100644 i386/i386/cpu_number.c > create mode 100644 i386/

[PATCH] [ipc_kmsg.c] Set kr if copy cannot be copied to user space

2023-01-23 Thread Flavio Cruz
Compiler will complain otherwise that kr is not initialized. --- ipc/ipc_kmsg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ipc/ipc_kmsg.c b/ipc/ipc_kmsg.c index 2c9d4988..dac4f5dc 100644 --- a/ipc/ipc_kmsg.c +++ b/ipc/ipc_kmsg.c @@ -2466,8 +2466,10 @@ ipc_kmsg_copyout_b

[PATCH] [x86_64] dev_pager.c: use mach_msg_type_number_t

2023-01-23 Thread Flavio Cruz
Otherwise it will fail to compile due to conflicting types. --- device/dev_pager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/device/dev_pager.c b/device/dev_pager.c index 728be036..d9d22489 100644 --- a/device/dev_pager.c +++ b/device/dev_pager.c @@ -494,7 +494,7 @@ devic

Re: [PATCH] Use -O2 -g by default when compiling

2023-01-23 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le sam. 21 janv. 2023 21:42:12 -0500, a ecrit: > After d5e5dd3401ea0d0475aa830c2171be5b8a72f4fa we can configure and make > gnumach without glibc, however it no longer used -O2 -g in CFLAGS by default. > This reverts that behavior. > --- > configure.ac | 4 > 1

Re: [PATCH] Fix several warnings for -Wmissing-prototypes

2023-01-23 Thread Samuel Thibault
Hello, Applied, except Flavio Cruz, le ven. 20 janv. 2023 01:19:53 -0500, a ecrit: > * ddb/db_mp.c: remove unused function. > diff --git a/ddb/db_mp.c b/ddb/db_mp.c > index 7c0f6f26..dbd4abb8 100644 > --- a/ddb/db_mp.c > +++ b/ddb/db_mp.c > @@ -246,17 +246,6 @@ db_on(int cpu) > db_cont