Re: [PATCH] Include mig generated headers to avoid warnings with -Wmissing-prototypes.

Applied, thanks! Flavio Cruz, le mar. 17 janv. 2023 23:56:04 -0500, a ecrit: > diff --git a/ddb/db_aout.c b/ddb/db_aout.c > index 8f344d6d..7b769c1c 100644 > --- a/ddb/db_aout.c > +++ b/ddb/db_aout.c > @@ -75,7 +75,7 @@ aout_db_sym_init( > char * esymtab,/* pointer to end of string

Re: [PATCH v2 rumpkernel] pci-userspace: Add acpi lookup of irqs with fallback

Applied, thanks! Damien Zammit, le mer. 18 janv. 2023 07:36:18 +, a ecrit: > --- > debian/patches/acpi.diff | 78 > debian/patches/series| 1 + > 2 files changed, 79 insertions(+) > create mode 100644 debian/patches/acpi.diff > > diff --git a/de

Re: [PATCH] Fix some compiler warnings

Applied, thanks! Svante Signell, le mer. 18 janv. 2023 13:29:48 +0100, a ecrit: > On Wed, 2023-01-18 at 12:27 +0100, Samuel Thibault wrote: > > Svante Signell, le mer. 18 janv. 2023 11:59:40 +0100, a ecrit: > > > On Wed, 2023-01-18 at 02:02 +0100, Samuel Thibault wrote: > > > > Hello, > > > > > >

Re: [PATCH] Fix some compiler warnings

On Wed, 2023-01-18 at 12:27 +0100, Samuel Thibault wrote: > Svante Signell, le mer. 18 janv. 2023 11:59:40 +0100, a ecrit: > > On Wed, 2023-01-18 at 02:02 +0100, Samuel Thibault wrote: > > > Hello, > > > > > > > > > But conversely when we'll build it in 64bit, vm_page_size > > > (actually uintptr

Re: [PATCH] Add libraries to Makefiles.

Svante Signell, le mer. 18 janv. 2023 12:36:55 +0100, a ecrit: > On Wed, 2023-01-18 at 11:54 +0100, Samuel Thibault wrote: > > > > Then you need to check that the linking of e.g. storeio does use the > > shared library and not the static library. For instance you can re-run > > the corresponding l

Re: [PATCH] Add libraries to Makefiles.

On Wed, 2023-01-18 at 11:54 +0100, Samuel Thibault wrote: > > Then you need to check that the linking of e.g. storeio does use the > shared library and not the static library. For instance you can re-run > the corresponding linking command and add -Wl,-verbose to check in the > verbose output whic

Re: [PATCH] Fix some compiler warnings

Svante Signell, le mer. 18 janv. 2023 11:59:40 +0100, a ecrit: > On Wed, 2023-01-18 at 02:02 +0100, Samuel Thibault wrote: > > Hello, > > > > > > But conversely when we'll build it in 64bit, vm_page_size (actually > > uintptr_t) will be an unsigned long. > > > > This needs to be fixed the *prope

Re: [PATCH] Fix some compiler warnings

On Wed, 2023-01-18 at 02:02 +0100, Samuel Thibault wrote: > Hello, > > > But conversely when we'll build it in 64bit, vm_page_size (actually > uintptr_t) will be an unsigned long. > > This needs to be fixed the *proper* way: either use the PRIuPTR > macro, or cast the value into unsigned long.

Re: [PATCH] Add libraries to Makefiles.

Svante Signell, le mer. 18 janv. 2023 11:34:32 +0100, a ecrit: > On Wed, 2023-01-18 at 11:10 +0100, Samuel Thibault wrote: > > > > That's not enough information: I'm asking about your cross-toolchain. > > > > Do you actually get e.g. libstore/libstore.so for instance? > > If so, run objdump -x on

Re: [PATCH] Add libraries to Makefiles.

On Wed, 2023-01-18 at 11:10 +0100, Samuel Thibault wrote: > > That's not enough information: I'm asking about your cross-toolchain. > > Do you actually get e.g. libstore/libstore.so for instance? > If so, run objdump -x on it and check that libz is indeed in NEEDED. > That's what is supposed to s

Re: [PATCH] Add libraries to Makefiles.

Svante Signell, le mer. 18 janv. 2023 11:05:17 +0100, a ecrit: > On Wed, 2023-01-18 at 01:54 +0100, Samuel Thibault wrote: > > But none of these directories are actually using libz, so it doesn't > > make sense to make them use -lz. > > > > Are you sure that your cross-toolchain supports linking s

Re: [PATCH] Add libraries to Makefiles.

On Wed, 2023-01-18 at 01:54 +0100, Samuel Thibault wrote: > Hello, > > But none of these directories are actually using libz, so it doesn't > make sense to make them use -lz. > > Are you sure that your cross-toolchain supports linking shared > libraries? Here are the configure flags: CPPFLAGS