Re: [PATCH] Use mach_port_name_t in a few more places

2022-12-02 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le jeu. 01 déc. 2022 00:42:57 -0500, a ecrit: > A few places that I missed in 958686efa2175abe3f7044890c2c2370e29147f2. > --- > ipc/mach_debug.c | 2 +- > ipc/mach_msg.c | 2 +- > ipc/mach_port.c | 6 +++--- > ipc/port.h | 9 - > 4 files changed, 9 i

Re: [PATCH v3] hurd: Make getrandom cache the server port

2022-12-02 Thread Samuel Thibault
Samuel Thibault, le ven. 02 déc. 2022 23:46:21 +0100, a ecrit: > Fixed the indentation and commited, thanks! I have also uploaded a glibc version 2.36-7~0 to unreleased, so people can easily upgrade to it and get openssh 9.1 working. Samuel > Sergey Bugaev, le ven. 02 déc. 2022 16:55:58 +0300, a

Re: [PATCH v3] hurd: Make getrandom cache the server port

2022-12-02 Thread Samuel Thibault
Fixed the indentation and commited, thanks! Samuel Sergey Bugaev, le ven. 02 déc. 2022 16:55:58 +0300, a ecrit: > Changes since v2: > * Bring back support for reading /dev/random if so requested with > GRND_RANDOM; > * Fix 'git commit' having eaten a #define in the commit message; > * Do not pa

Re: [PATCH v3] hurd: Make getrandom cache the server port

2022-12-02 Thread Sergey Bugaev
On Fri, Dec 2, 2022 at 4:56 PM Sergey Bugaev wrote: > + switch (flags) > +{ > +case 0: > + cached_server = &urandom_server; > + break; > +case GRND_RANDOM: > + cached_server = &random_server; > + break; > +case GRND_NONBLOCK: > + cached_server = &urandom_s

[PATCH v3] hurd: Make getrandom cache the server port

2022-12-02 Thread Sergey Bugaev
Changes since v2: * Bring back support for reading /dev/random if so requested with GRND_RANDOM; * Fix 'git commit' having eaten a #define in the commit message; * Do not pass O_NOCTTY, because: a) O_NOCTTY is 0; I mixed it up with O_IGNORE_CTTY, b) we're not opening an fd anyway, so it's irr

Re: [PATCH v2] hurd: Make getrandom cache the server port

2022-12-02 Thread Samuel Thibault
Sergey Bugaev, le ven. 02 déc. 2022 16:18:33 +0300, a ecrit: > On Fri, Dec 2, 2022 at 12:17 PM Samuel Thibault > wrote: > > Sergey Bugaev, le ven. 02 déc. 2022 12:13:51 +0300, a ecrit: > > > Caveat: this new implementation does not respect the GRND_RANDOM flag > > > and always uses /dev/urandom t

Re: [PATCH v2] hurd: Make getrandom cache the server port

2022-12-02 Thread Sergey Bugaev
On Fri, Dec 2, 2022 at 12:17 PM Samuel Thibault wrote: > > Hello, > > Sergey Bugaev, le ven. 02 déc. 2022 12:13:51 +0300, a ecrit: > > Caveat: this new implementation does not respect the GRND_RANDOM flag > > and always uses /dev/urandom to read random data. > > It should be easy to fix that? > By

Re: lost ssh access - where is a log?

2022-12-02 Thread Riccardo Mottola
Hi, Sergey Bugaev wrote: On Tue, Nov 29, 2022 at 7:34 AM Guy-Fleury Iteriteka wrote: There is a thread from bugaev that explain the issue and a partial fix : https://floss.social/@bugaevc/109422269238549581 Well, I guess that's my cue to wave hi to this list :) Welcome back! or citing, sa

Re: [PATCH v2] hurd: Make getrandom cache the server port

2022-12-02 Thread Samuel Thibault
Hello, Sergey Bugaev, le ven. 02 déc. 2022 12:13:51 +0300, a ecrit: > Caveat: this new implementation does not respect the GRND_RANDOM flag > and always uses /dev/urandom to read random data. It should be easy to fix that? > +static file_t random_server, random_server_nonblock; By adding a seco

[PATCH v2] hurd: Make getrandom cache the server port

2022-12-02 Thread Sergey Bugaev
Previously, getrandom would, each time it's called, traverse the file system to find /dev/urandom, fetch some random data from it, then throw away that port. This is quite slow, while calls to getrandom are genrally expected to be fast. Additionally, this means that getrandom can not work when /de