Re: [PATCH] Initialize basic types once and print errors for duplicate definitions

Applied, thanks! Flavio Cruz, le lun. 14 nov. 2022 00:40:07 -0500, a ecrit: > For kernel server or user subsystems we would initialize basic types > twice, once in main() and again for the subsystem declaration. Instead, > initialize basic types when the subsystem is declared and then throw > erro

Re: [PATCH 3/4] Add cpu_number and cpuboot

Damien Zammit, le ven. 11 nov. 2022 23:21:28 +, a ecrit: > diff --git a/i386/i386/cpu_number.c b/i386/i386/cpu_number.c > new file mode 100644 > index ..d4621669 > --- /dev/null > +++ b/i386/i386/cpu_number.c > +#if NCPUS > 1 > +int cpu_number(void) > +{ > + int kernel_id; > + u

Re: [PATCH] Remove include of hurd/hurd_types.defs in iioctl.defs and rioctl.defs

Flavio Cruz, le lun. 14 nov. 2022 00:38:47 -0500, a ecrit: > hurd/hurd_types.defs is already included through ioctl_types.defs. Applied, thanks! > --- > hurd/iioctl.defs | 1 - > hurd/rioctl.defs | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/hurd/iioctl.defs b/hurd/iioctl.defs > ind

Re: [PATCH 2/4] i386: Fix lapic and ioapic for smp

Almudena Garcia, le mar. 15 nov. 2022 01:48:52 +0100, a ecrit: > > Again, we need a memory barrier, to prevent the compiler from emitting > these writes in the wrong order. > > Really, these writes are using a temporary struct. > There are a only write to the real register, which is done assignin

Re: [PATCH 4/4] i386: Refactor int stacks to be per cpu for SMP

Damien Zammit, le ven. 11 nov. 2022 23:21:38 +, a ecrit: > diff --git a/i386/i386/cpu_number.h b/i386/i386/cpu_number.h > index 9aef6370..d56cb602 100644 > --- a/i386/i386/cpu_number.h > +++ b/i386/i386/cpu_number.h > @@ -35,14 +35,35 @@ > /* More-specific code must define cpu_number() and CPU

Re: [PATCH 2/4] i386: Fix lapic and ioapic for smp

> Again, we need a memory barrier, to prevent the compiler from emitting these writes in the wrong order. Really, these writes are using a temporary struct. There are a only write to the real register, which is done assigning the temporary struct to the real register through the HAL El mar., 15 n

Re: [PATCH 1/4] i386: Add AP variants of descriptor tables

Hello, We're converging :) Samuel Damien Zammit, le ven. 11 nov. 2022 23:21:15 +, a ecrit: > -void idt_init(void) > +static void > +idt_fill(struct real_gate *myidt) > { > #ifdef MACH_PV_DESCRIPTORS > if (hyp_set_trap_table(kvtolin(idt_inittab))) > @@ -47,18 +49,29 @@ void idt_

[PATCH] Initialize basic types once and print errors for duplicate definitions

For kernel server or user subsystems we would initialize basic types twice, once in main() and again for the subsystem declaration. Instead, initialize basic types when the subsystem is declared and then throw errors when types are defined multiple times. --- migcom.c | 1 - parser.y | 5 ++---

Re: [PATCH 2/4] i386: Fix lapic and ioapic for smp

Damien Zammit, le ven. 11 nov. 2022 23:21:22 +, a ecrit: > diff --git a/i386/i386/apic.c b/i386/i386/apic.c > index d30084e2..6a5fa754 100644 > --- a/i386/i386/apic.c > +++ b/i386/i386/apic.c > @@ -19,6 +19,8 @@ > Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. */ >

[PATCH] Remove include of hurd/hurd_types.defs in iioctl.defs and rioctl.defs

hurd/hurd_types.defs is already included through ioctl_types.defs. --- hurd/iioctl.defs | 1 - hurd/rioctl.defs | 1 - 2 files changed, 2 deletions(-) diff --git a/hurd/iioctl.defs b/hurd/iioctl.defs index 78521795..bd2c789f 100644 --- a/hurd/iioctl.defs +++ b/hurd/iioctl.defs @@ -21,7 +21,6 @@ t