[PATCH] pci-arbiter: Remove invalid pci_device_close

2022-02-26 Thread Damien Zammit
pci_control_port is not a port info so calling deref on it is invalid. There seems no reason to have a device_close for the pci device currently so remove it. Perhaps some logic needs to be added to prevent concurrent pci accesses by multiple clients since some pci commands are non-atomic (?) TES

Re: [PATCH] libmachdev: Switch machdev_server to multithreaded (rumpdisk)

2022-02-26 Thread Samuel Thibault
Damien Zammit, le dim. 27 févr. 2022 07:17:10 +, a ecrit: > TESTED via booting a rump disk Errr, we can't just change libmachdev like that, there are several users of it which may not be threadsafe at all. Rather export the demuxer function and let users call ports_manage_port_operations_multi

[PATCH] libmachdev: Switch machdev_server to multithreaded (rumpdisk)

2022-02-26 Thread Damien Zammit
TESTED via booting a rump disk --- libmachdev/ds_routines.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libmachdev/ds_routines.c b/libmachdev/ds_routines.c index 139551f6..6c150c8f 100644 --- a/libmachdev/ds_routines.c +++ b/libmachdev/ds_routines.c @@ -351,7 +351,11

Re: [PATCH] rumpdisk: Protect open/close/read/write with a rwlock

2022-02-26 Thread Samuel Thibault
Damien Zammit, le dim. 27 févr. 2022 00:27:02 +, a ecrit: > TESTED to boot off a rump based disk Applied, thanks! > --- > rumpdisk/block-rump.c | 77 --- > 1 file changed, 66 insertions(+), 11 deletions(-) > > diff --git a/rumpdisk/block-rump.c b/rump

[PATCH] rumpdisk: Protect open/close/read/write with a rwlock

2022-02-26 Thread Damien Zammit
TESTED to boot off a rump based disk --- rumpdisk/block-rump.c | 77 --- 1 file changed, 66 insertions(+), 11 deletions(-) diff --git a/rumpdisk/block-rump.c b/rumpdisk/block-rump.c index 10fa66ad..464c5cdd 100644 --- a/rumpdisk/block-rump.c +++ b/rumpdisk

[PATCH] hurd: Use part: qualifier

2022-02-26 Thread Samuel Thibault
When using userland drivers such as rumpdisk, we'd rather make ext2fs use parted-based libstore partitioning support. That can be used for kernelland drivers as well, so we can just make grub always use the part: qualifier to switch ext2fs to it. grub_util_find_hurd_root_device then has to underst

Re: [PATCH] rumpdisk: Protect device_open/close and r/w with a mutex for threading

2022-02-26 Thread Samuel Thibault
Damien Zammit, le sam. 26 févr. 2022 06:29:21 +, a ecrit: > @@ -233,22 +246,32 @@ rumpdisk_device_open (mach_port_t reply_port, > mach_msg_type_name_t reply_port_ty >bd = search_bd (name); You also need to protect the list, against concurrent addition of elements. > @@ -296,6 +323,8 @@ r