Re: Dropping gdc support?

Unfortunately. I was jut going to look into that problem... On Sun, 2022-01-23 at 22:56 +0100, Samuel Thibault wrote: > Samuel Thibault, le dim. 16 janv. 2022 21:19:17 +0100, a ecrit: > > otherwise I'll soon ask to just drop the gdc support from > > gcc-12 > > Apparently doko already did it. > >

Re: Dropping gdc support?

Samuel Thibault, le dim. 16 janv. 2022 21:19:17 +0100, a ecrit: > otherwise I'll soon ask to just drop the gdc support from > gcc-12 Apparently doko already did it. Samuel

Re: [PATCH] hurd: Implement device memory mapping

Joan Lledó, le dim. 23 janv. 2022 18:35:58 +0100, a ecrit: > El 9/1/22 a les 1:02, Samuel Thibault ha escrit: > > Err, this is breaking everything when pci-arbiter is not running as a > > bootstrap translator. In that case e.g. netdde succeeds getting the > > privileged port, and thus tries to open

Re: [PATCH] hurd: Implement device memory mapping

Hi, El 9/1/22 a les 1:02, Samuel Thibault ha escrit: Err, this is breaking everything when pci-arbiter is not running as a bootstrap translator. In that case e.g. netdde succeeds getting the privileged port, and thus tries to open pci, but fails, and thus the whole thing aborts. What problem the

Re: [PATCH 13/17] ext2fs: remove a #define not_yet

> Le dim. 23 janv. 2022 à 10:40, Samuel Thibault <[1]samuel.thiba...@gnu.org> a > écrit : > > Etienne Brateau, le dim. 23 janv. 2022 05:17:11 +0100, a ecrit: > > ext2fs will never support time precision better than second > > ? There is *_ctime_extra in newer definitions of the filesy

Re: [PATCH 06/17] ext2fs: reindent files

On 23 Jan 2022, at 15:02, Etienne Brateau wrote: > > The reindent part is mainly to replace tabs characters by spaces. Maybe the > reindentation is not following the GNU convention (aka 8 spaces) but is > following the general convention of the files. I can redo it by using 8 > spaces if neede

Re: [PATCH 13/17] ext2fs: remove a #define not_yet

Not in ext2. It was added in ext4. Le dim. 23 janv. 2022 à 10:40, Samuel Thibault a écrit : > Etienne Brateau, le dim. 23 janv. 2022 05:17:11 +0100, a ecrit: > > ext2fs will never support time precision better than second > > ? There is *_ctime_extra in newer definitions of the filesystem. > > >

Re: [PATCH 17/17] ext2fs: remove 2 unused functions

Maybe yes, for debug purposes Le dim. 23 janv. 2022 à 10:48, Samuel Thibault a écrit : > They might still be useful some day? > > Etienne Brateau, le dim. 23 janv. 2022 05:17:15 +0100, a ecrit: > > --- > > ext2fs/ialloc.c | 72 - > > 1 file change

Re: [PATCH 08/17] ext2fs: Take cares of indiannes

Samuel Thibault, le dim. 23 janv. 2022 12:04:14 +0100, a ecrit: > Etienne Brateau, le dim. 23 janv. 2022 05:17:06 +0100, a ecrit: > > In ext2 data are stored in little endian to ensure portability. So > > enforce little endian when manipulating these bytes. > > Applied, thanks! > > I have spotted

Re: [PATCH 15/17] Change a EIO by a ENOSPC in case where not enough space

Applied, thanks! Etienne Brateau, le dim. 23 janv. 2022 05:17:13 +0100, a ecrit: > Return a ENOSPC to notify that not enough space is here after the > xattr entry instead of returning an EIO. > --- > ext2fs/xattr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ext2fs/x

Re: [PATCH 14/17] ext2fs: refactor add a method for dupplicated code

Applied, thanks! Etienne Brateau, le dim. 23 janv. 2022 05:17:12 +0100, a ecrit: > * xattr: introduce xattr_header_valid method > --- > ext2fs/xattr.c | 22 ++ > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/ext2fs/xattr.c b/ext2fs/xattr.c > index 0c8556

Re: [PATCH 12/17] ext2fs: detect and warn when filesystem is an ext3 fs

Applied, thanks! Etienne Brateau, le dim. 23 janv. 2022 05:17:10 +0100, a ecrit: > --- > ext2fs/hyper.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ext2fs/hyper.c b/ext2fs/hyper.c > index 9bff609f..ac18bbf1 100644 > --- a/ext2fs/hyper.c > +++ b/ext2fs/hyper.c > @@ -134,6 +134,8 @@

Re: [PATCH 11/17] ext2fs: resolve a todo, check writability before writing

Applied, thanks! Etienne Brateau, le dim. 23 janv. 2022 05:17:09 +0100, a ecrit: > --- > ext2fs/hyper.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ext2fs/hyper.c b/ext2fs/hyper.c > index 65a2937e..9bff609f 100644 > --- a/ext2fs/hyper.c > +++ b/ext2fs/hyper.c > @@

Re: [PATCH 10/17] ext2fs: set the writing time in the superblock

Applied, thanks! Etienne Brateau, le dim. 23 janv. 2022 05:17:08 +0100, a ecrit: > --- > ext2fs/hyper.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ext2fs/hyper.c b/ext2fs/hyper.c > index 1bb74e53..65a2937e 100644 > --- a/ext2fs/hyper.c > +++ b/ext2fs/hyper.c > @@ -199,6 +199,8 @@

Re: [PATCH 09/17] ext2fs: set the f_namelen to the correct value

Applied, thanks! Etienne Brateau, le dim. 23 janv. 2022 05:17:07 +0100, a ecrit: > --- > ext2fs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ext2fs/inode.c b/ext2fs/inode.c > index 47d05f47..511faf6e 100644 > --- a/ext2fs/inode.c > +++ b/ext2fs/inode.c > @@ -5

Re: [PATCH 08/17] ext2fs: Take cares of indiannes

Etienne Brateau, le dim. 23 janv. 2022 05:17:06 +0100, a ecrit: > In ext2 data are stored in little endian to ensure portability. So > enforce little endian when manipulating these bytes. Applied, thanks! I have spotted and fixed a few missing bits, it's probably worth another review round. > --

Re: [PATCH 07/17] ext2fs: use macro to check flags

Etienne Brateau, le dim. 23 janv. 2022 05:17:05 +0100, a ecrit: > * hyper.c: use macros to check flags Applied, thanks! > --- > ext2fs/hyper.c | 30 -- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/ext2fs/hyper.c b/ext2fs/hyper.c > index 93fb

Re: [PATCH 05/17] ext2fs: remove unneeded file

Applied, thanks! Etienne Brateau, le dim. 23 janv. 2022 05:17:03 +0100, a ecrit: > --- > ext2fs/sblock.words | 6 -- > 1 file changed, 6 deletions(-) > delete mode 100644 ext2fs/sblock.words > > diff --git a/ext2fs/sblock.words b/ext2fs/sblock.words > deleted file mode 100644 > index e17b8f

Re: [PATCH 04/17] move to ext2_fs.h a #define

Etienne Brateau, le dim. 23 janv. 2022 05:17:02 +0100, a ecrit: > This makes all #define be grouped at the same place Applied, thanks! > --- > ext2fs/ext2_fs.h | 1 + > ext2fs/ext2fs.h | 6 -- > ext2fs/ialloc.c | 3 +++ > 3 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/e

Re: [PATCH 03/17] ext2fs: remove __KERNEL__

Etienne Brateau, le dim. 23 janv. 2022 05:17:01 +0100, a ecrit: > This makes the header more clear and btw it’s not anymore in the linux tree Applied modulo some typo in EXT2_DESC_PER_BLOCK and EXT2_INODES_PER_GROUP, thanks! > --- > ext2fs/ext2_fs.h | 247 ---

Re: [PATCH 02/17] ext2fs: update ext2_fs.h header

Applied except the debug parts which can still be useful, thanks! Etienne Brateau, le dim. 23 janv. 2022 05:17:00 +0100, a ecrit: > --- > ext2fs/ext2_fs.h | 122 ++- > ext2fs/ext2fs.h | 3 -- > 2 files changed, 89 insertions(+), 36 deletions(-) > >

Re: [PATCH 01/17] ext2fs Merge 2 headers

Etienne Brateau, le dim. 23 janv. 2022 05:16:59 +0100, a ecrit: > * ext2_fs_i.h: merge it into ext2_fs.h. This is also done in the linux tree Applied, thanks! > --- > ext2fs/ext2_fs.h | 22 ++ > ext2fs/ext2_fs_i.h | 41 - > ext2fs/e

Re: [PATCH 17/17] ext2fs: remove 2 unused functions

They might still be useful some day? Etienne Brateau, le dim. 23 janv. 2022 05:17:15 +0100, a ecrit: > --- > ext2fs/ialloc.c | 72 - > 1 file changed, 72 deletions(-) > > diff --git a/ext2fs/ialloc.c b/ext2fs/ialloc.c > index 568d7eae..e1a09a82 100

Re: [PATCH 16/17] ext2fs: remove a commented block of code

We need to record why it's actually not needed in the git log. Etienne Brateau, le dim. 23 janv. 2022 05:17:14 +0100, a ecrit: > --- > ext2fs/ialloc.c | 34 -- > 1 file changed, 8 insertions(+), 26 deletions(-) > > diff --git a/ext2fs/ialloc.c b/ext2fs/ialloc.c >

Re: [PATCH 13/17] ext2fs: remove a #define not_yet

Etienne Brateau, le dim. 23 janv. 2022 05:17:11 +0100, a ecrit: > ext2fs will never support time precision better than second ? There is *_ctime_extra in newer definitions of the filesystem. > --- > ext2fs/inode.c | 25 +++-- > 1 file changed, 3 insertions(+), 22 deletions(-)