[PATCH] Add _Static_assert when compiling server and user stubs.

2022-01-19 Thread Flavio Cruz
This is only done when data is inlined with a concrete size. It ensures the C and Mig types have the same size in the target arch. Tested by building the hurd package. No assertions were triggered. --- server.c | 4 ++-- tests/good/case.defs | 6 -- tests/includes/types.h |

Re: [PATCH 7/7] proc: Fix variable type

2022-01-19 Thread Samuel Thibault
Etienne Brateau, le mer. 19 janv. 2022 20:29:45 +0100, a ecrit: > --- > proc/pgrp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/proc/pgrp.c b/proc/pgrp.c > index 07e587a3..2995bb1e 100644 > --- a/proc/pgrp.c > +++ b/proc/pgrp.c > @@ -182,7 +182,7 @@ S_proc_getsessionp

Re: [PATCH 6/7] libnetfs: fix type of variable

2022-01-19 Thread Samuel Thibault
Applied, thanks! Etienne Brateau, le mer. 19 janv. 2022 20:29:44 +0100, a ecrit: > --- > libnetfs/file-get-translator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libnetfs/file-get-translator.c b/libnetfs/file-get-translator.c > index 635653de..2dff6a13 100644 > ---

Re: [PATCH 5/7] libps: fix some signed vs unsigned comparision

2022-01-19 Thread Samuel Thibault
Applied, thanks! Etienne Brateau, le mer. 19 janv. 2022 20:29:43 +0100, a ecrit: > --- > libps/proclist.c | 2 +- > libps/write.c| 8 > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libps/proclist.c b/libps/proclist.c > index 4e2174ac..c9ceaf0a 100644 > --- a/lib

Re: [PATCH 4/7] libdiskfs: improve asserts and remove a sign compare warning

2022-01-19 Thread Samuel Thibault
Applied, thanks! Etienne Brateau, le mer. 19 janv. 2022 20:29:42 +0100, a ecrit: > --- > libdiskfs/boot-start.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libdiskfs/boot-start.c b/libdiskfs/boot-start.c > index 5c4c3248..89d09d65 100644 > --- a/libdiskfs/boot-star

Re: [PATCH 3/7] libstore: fix type of a counter

2022-01-19 Thread Samuel Thibault
Applied, thanks! Etienne Brateau, le mer. 19 janv. 2022 20:29:41 +0100, a ecrit: > --- > libstore/argp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libstore/argp.c b/libstore/argp.c > index a399b48f..31bae116 100644 > --- a/libstore/argp.c > +++ b/libstore/argp.c >

Re: [PATCH 2/7] libpager: fix assertion unsigned against 0

2022-01-19 Thread Samuel Thibault
Etienne Brateau, le mer. 19 janv. 2022 20:29:40 +0100, a ecrit: > Comparing an unsigned to be superior or equals to 0 is always true, > instead move the assert before the substraction and compare it to the > value to substract. Applied, thanks! > --- > libpager/pager-memcpy.c | 6 +++--- > 1 fil

Re: [PATCH 1/7] libpager: fix a comparision between signed and unsigned

2022-01-19 Thread Samuel Thibault
I have rather changed it to vm_size_t, which makes much more sense here. Etienne Brateau, le mer. 19 janv. 2022 20:29:39 +0100, a ecrit: > --- > libpager/lock-object.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libpager/lock-object.c b/libpager/lock-object.c > index

[PATCH 5/7] libps: fix some signed vs unsigned comparision

2022-01-19 Thread Etienne Brateau
--- libps/proclist.c | 2 +- libps/write.c| 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libps/proclist.c b/libps/proclist.c index 4e2174ac..c9ceaf0a 100644 --- a/libps/proclist.c +++ b/libps/proclist.c @@ -120,7 +120,7 @@ proc_stat_list_add_pids (struct proc_stat

[PATCH 6/7] libnetfs: fix type of variable

2022-01-19 Thread Etienne Brateau
--- libnetfs/file-get-translator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libnetfs/file-get-translator.c b/libnetfs/file-get-translator.c index 635653de..2dff6a13 100644 --- a/libnetfs/file-get-translator.c +++ b/libnetfs/file-get-translator.c @@ -66,7 +66,7 @@ netfs_S

[PATCH 7/7] proc: Fix variable type

2022-01-19 Thread Etienne Brateau
--- proc/pgrp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proc/pgrp.c b/proc/pgrp.c index 07e587a3..2995bb1e 100644 --- a/proc/pgrp.c +++ b/proc/pgrp.c @@ -182,7 +182,7 @@ S_proc_getsessionpids (struct proc *callerp, pid_t **pids,

[PATCH 3/7] libstore: fix type of a counter

2022-01-19 Thread Etienne Brateau
--- libstore/argp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libstore/argp.c b/libstore/argp.c index a399b48f..31bae116 100644 --- a/libstore/argp.c +++ b/libstore/argp.c @@ -198,7 +198,7 @@ store_parsed_open (const struct store_parsed *parsed, int flags, return op

[PATCH 4/7] libdiskfs: improve asserts and remove a sign compare warning

2022-01-19 Thread Etienne Brateau
--- libdiskfs/boot-start.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libdiskfs/boot-start.c b/libdiskfs/boot-start.c index 5c4c3248..89d09d65 100644 --- a/libdiskfs/boot-start.c +++ b/libdiskfs/boot-start.c @@ -249,7 +249,8 @@ diskfs_start_bootstrap () diskfs_ker

[PATCH 1/7] libpager: fix a comparision between signed and unsigned

2022-01-19 Thread Etienne Brateau
--- libpager/lock-object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libpager/lock-object.c b/libpager/lock-object.c index c022d0c4..bb222ea6 100644 --- a/libpager/lock-object.c +++ b/libpager/lock-object.c @@ -30,7 +30,7 @@ _pager_lock_object (struct pager *p,

[PATCH 2/7] libpager: fix assertion unsigned against 0

2022-01-19 Thread Etienne Brateau
Comparing an unsigned to be superior or equals to 0 is always true, instead move the assert before the substraction and compare it to the value to substract. --- libpager/pager-memcpy.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libpager/pager-memcpy.c b/libpager/pag