Re: [RFC PATCH glibc 2/3] XXX: Move __pthread_threads to ld.so

2021-05-15 Thread Samuel Thibault
Sergey Bugaev, le sam. 15 mai 2021 20:07:35 +0300, a ecrit: > On Sat, May 15, 2021 at 5:09 PM Samuel Thibault > wrote: > > This can't go to the generic-purpose dl-support.c file. > > Create a sysdeps/mach/hurd/dl-thread_gscope_wait.c file, it's already > > getting included by elf/Makefile's routi

Re: [RFC PATCH glibc 2/3] XXX: Move __pthread_threads to ld.so

2021-05-15 Thread Sergey Bugaev
On Sat, May 15, 2021 at 5:09 PM Samuel Thibault wrote: > This can't go to the generic-purpose dl-support.c file. > Create a sysdeps/mach/hurd/dl-thread_gscope_wait.c file, it's already > getting included by elf/Makefile's routine variable. I'm creating sysdeps/htl/dl-thread_gscope_wait.c in the n

Re: rpctrace output improvements?

2021-05-15 Thread Sergey Bugaev
On Sat, May 15, 2021 at 4:56 PM Samuel Thibault wrote: > > * rpctrace has to learn to parse defs, instead of (or in addition to) msgids > > * GNU MIG needs to be taught to emit more info into msgids files > > Either of those. Probably the latter would be more interesting > long-term. We could intr

Re: [RFC PATCH glibc 0/3] Rewrite THREAD_GSCOPE

2021-05-15 Thread Samuel Thibault
Overall it looks nice, there is just patch 1/3 that probably needs discussion on libc-alpha to check how they'd rather see it. Once that's in, we can easily install the other two patches once revised. Samuel

Re: [RFC PATCH glibc 3/3] XXX: Reimplement gscope

2021-05-15 Thread Samuel Thibault
Sergey Bugaev, le dim. 09 mai 2021 16:54:04 +0300, a ecrit: > diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h > index 4604d00b..af16162f 100644 > --- a/sysdeps/generic/ldsodefs.h > +++ b/sysdeps/generic/ldsodefs.h > @@ -1324,10 +1324,8 @@ link_map_audit_state (struct link_map *

Re: [RFC PATCH glibc 2/3] XXX: Move __pthread_threads to ld.so

2021-05-15 Thread Samuel Thibault
Samuel Thibault, le sam. 15 mai 2021 16:16:34 +0200, a ecrit: > Sergey Bugaev, le dim. 09 mai 2021 16:54:03 +0300, a ecrit: > > + lll_lock (GL (dl_pthread_threads_lock), 0); > > Actually all of these can use LLL_PRIVATE to make it cheaper in the > contented case. (which is actually 0 indeed, but

Re: [RFC PATCH glibc 2/3] XXX: Move __pthread_threads to ld.so

2021-05-15 Thread Samuel Thibault
Sergey Bugaev, le dim. 09 mai 2021 16:54:03 +0300, a ecrit: > + lll_lock (GL (dl_pthread_threads_lock), 0); Actually all of these can use LLL_PRIVATE to make it cheaper in the contented case. Samuel

Re: [RFC PATCH glibc 0/3] Rewrite THREAD_GSCOPE

2021-05-15 Thread Samuel Thibault
Sergey Bugaev, le dim. 09 mai 2021 16:54:01 +0300, a ecrit: > (For instance, how do I even add a new source file to a library? You add its name in the routines variable. > Or where does it decide which system-specific parts to build, such as > whether to build NPTL or HTL? It's set in the Depend

Re: [RFC PATCH glibc 2/3] XXX: Move __pthread_threads to ld.so

2021-05-15 Thread Samuel Thibault
Sergey Bugaev, le dim. 09 mai 2021 16:54:03 +0300, a ecrit: > index af340bee..a55834a1 100644 > --- a/elf/dl-support.c > +++ b/elf/dl-support.c > @@ -194,7 +194,9 @@ list_t _dl_stack_used; > list_t _dl_stack_user; > int _dl_stack_cache_lock; > #else > -int _dl_thread_gscope_count; > +int _dl_pth

Re: [RFC PATCH glibc 1/3] XXX: Rename THREAD_GSCOPE_IN_TCB -> THREAD_GSCOPE_LINK_MAP

2021-05-15 Thread Samuel Thibault
Sergey Bugaev, le dim. 09 mai 2021 16:54:02 +0300, a ecrit: > I've noticed that THREAD_GSCOPE_IN_TCB is actually being used not to > check whether the thread global scope state is being stored in TCB, > but rather as a general flag to distinguish between NPTL and HTL. It used to really be for the

Re: rpctrace output improvements?

2021-05-15 Thread Samuel Thibault
Sergey Bugaev, le jeu. 13 mai 2021 15:28:01 +0300, a ecrit: > On Wed, May 12, 2021 at 11:48 PM Samuel Thibault > wrote: > > It'd probably mean introducing types > > here and there, but that'd be a really good thing to do. > > > > The port type is useful indeed and is most often available in the ty