Re: Bug#909436: libdrm 2.4.102-1: FTBFS on hurd-i386 (updated patches)

2021-04-26 Thread Samuel Thibault
Svante Signell, le mar. 27 avril 2021 01:04:30 +0200, a ecrit: > On Mon, 2021-04-26 at 23:43 +0200, Samuel Thibault wrote: > > For information, your patch got dropped because of #975658 > > Yes I know since a long time. Ok, I hadn't seen it. > And you did not care or anybody else either. Well,

Re: Bug#909436: libdrm 2.4.102-1: FTBFS on hurd-i386 (updated patches)

2021-04-26 Thread Svante Signell
On Mon, 2021-04-26 at 23:43 +0200, Samuel Thibault wrote: > Hello Svante, > > For information, your patch got dropped because of #975658 Yes I know since a long time. And you did not care or anybody else either. So why bother... Why spend time on worthless issues?

Re: [PATCH unionfs 3/3] Don't use strncat() with length derived from source string

2021-04-26 Thread Samuel Thibault
Sergey Bugaev, le lun. 26 avril 2021 22:34:45 +0300, a ecrit: > On Mon, Apr 26, 2021 at 9:02 PM Jessica Clarke wrote: > > > - strncpy (filepath, path, length); > > > - strncat (filepath, filename, strlen (filename)); > > > + strcpy (filepath, path); > > > + strcat (filepath, filename); > > > >

Re: [PATCH unionfs 3/3] Don't use strncat() with length derived from source string

2021-04-26 Thread Sergey Bugaev
On Mon, Apr 26, 2021 at 9:02 PM Jessica Clarke wrote: > > - strncpy (filepath, path, length); > > - strncat (filepath, filename, strlen (filename)); > > + strcpy (filepath, path); > > + strcat (filepath, filename); > > This is dubious. We should be using safe interfaces where possible. To exp

Re: [PATCH unionfs 1/3] Implement MiG intran payload support

2021-04-26 Thread Samuel Thibault
Sergey Bugaev, le lun. 26 avril 2021 20:08:18 +0300, a ecrit: > This fixes a build error. Applied, thanks! > --- > stow-mutations.h | 1 + > stow-priv.h | 4 > stow.c | 9 + > 3 files changed, 14 insertions(+) > > diff --git a/stow-mutations.h b/stow-mutations.h > in

Re: [PATCH unionfs 3/3] Don't use strncat() with length derived from source string

2021-04-26 Thread Samuel Thibault
Jessica Clarke, le lun. 26 avril 2021 19:02:54 +0100, a ecrit: > On 26 Apr 2021, at 18:08, Sergey Bugaev wrote: > > This fixes Wstringop-overflow and Wstringop-truncation GCC warnings. > > See https://gcc.gnu.org/bugzilla//show_bug.cgi?id=88059 > > > > Also, fix a bug where a string was not prope

Re: [PATCH unionfs 2/3] Add some missing includes

2021-04-26 Thread Samuel Thibault
Sergey Bugaev, le lun. 26 avril 2021 20:08:19 +0300, a ecrit: > This fixes multiple build errors. Applied, thanks! > --- > lib.c| 1 + > lib.h| 1 + > lnode.c | 1 + > lnode.h | 1 + > node.c | 1 + > stow.c | 2 ++ > ulfs.c | 1 + > update.c | 1 + > 8 files changed, 9 insertion

Re: [PATCH unionfs 3/3] Don't use strncat() with length derived from source string

2021-04-26 Thread Jessica Clarke
On 26 Apr 2021, at 18:08, Sergey Bugaev wrote: > > This fixes Wstringop-overflow and Wstringop-truncation GCC warnings. > See https://gcc.gnu.org/bugzilla//show_bug.cgi?id=88059 > > Also, fix a bug where a string was not properly null-terminated. > --- > lib.c | 4 ++-- > stow.c | 5 +++-- > 2 fi

[PATCH unionfs 1/3] Implement MiG intran payload support

2021-04-26 Thread Sergey Bugaev
This fixes a build error. --- stow-mutations.h | 1 + stow-priv.h | 4 stow.c | 9 + 3 files changed, 14 insertions(+) diff --git a/stow-mutations.h b/stow-mutations.h index d36280d..95c1e7f 100644 --- a/stow-mutations.h +++ b/stow-mutations.h @@ -21,6 +21,7 @@ /* Onl

[PATCH unionfs 0/3] Fix unionfs build errors

2021-04-26 Thread Sergey Bugaev
Hello, I'm trying to use unionfs [0]; but I've run into a few build errors and warnings. With the following patches it builds and works on the latest Debian GNU/Hurd with GCC 10. P.S. This is the first time I attempt sending patches over email, please let me know if I've done anything wrong. [0]

[PATCH unionfs 2/3] Add some missing includes

2021-04-26 Thread Sergey Bugaev
This fixes multiple build errors. --- lib.c| 1 + lib.h| 1 + lnode.c | 1 + lnode.h | 1 + node.c | 1 + stow.c | 2 ++ ulfs.c | 1 + update.c | 1 + 8 files changed, 9 insertions(+) diff --git a/lib.c b/lib.c index e7f3aa9..01cdbd0 100644 --- a/lib.c +++ b/lib.c @@ -23,6 +23,7 @

[PATCH unionfs 3/3] Don't use strncat() with length derived from source string

2021-04-26 Thread Sergey Bugaev
This fixes Wstringop-overflow and Wstringop-truncation GCC warnings. See https://gcc.gnu.org/bugzilla//show_bug.cgi?id=88059 Also, fix a bug where a string was not properly null-terminated. --- lib.c | 4 ++-- stow.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/lib.c