Re: [PATCH] SMP initialization: detection and enumeration

2020-08-12 Thread Samuel Thibault
Almudena Garcia, le jeu. 13 août 2020 00:35:36 +0200, a ecrit: > > Users do need that to understand what's happening. > But, if by any reason, the machine has more than cpu but the detection fails, > could be interesting to advise about the system being running with an only > cpu. > It's not? Yes

Re: [PATCH] SMP initialization: detection and enumeration

2020-08-12 Thread Almudena Garcia
> Applied and fixed a bit, thanks! Thanks. Now I only have to fix the next patches. We are closer now > But that will only enter if when api_success != 0, thus when we actually > have a failure. Compare explicitly against ACPI_SUCCESS Oops, I forget this. I will fix It. > Then there is no need

Re: [PATCH] SMP initialization: detection and enumeration OFF TOPIC PRAISE

2020-08-12 Thread Joshua Branson
Fair enough. I'll see if I can't try to help you in your project. Fair warning, I am a little out of my league here. Just writing plain ordinary C programs with pointers to strucks and memory management is hard for me. -- Joshua Branson Sent from Emacs and Gnus

Re: [PATCH] SMP initialization: detection and enumeration

2020-08-12 Thread Samuel Thibault
Almudena Garcia, le mar. 11 août 2020 02:17:35 +0200, a ecrit: > > What for? > > num_cpus is something that you make returned by a smp_get_numcpus() > > function, so it's not actually useful to also expose it in a struct. > > What else would go into that structure? > By example, the master cpu (BSP

Re: [PATCH] SMP initialization: detection and enumeration

2020-08-12 Thread Samuel Thibault
Almudena Garcia, le mer. 12 août 2020 16:03:06 +0200, a ecrit: > Subject: [PATCH 1/5] smp: Add pseudoclass to manage APIC operations Applied, thanks! > Subject: [PATCH 2/5] vm_kern: Add kmem_alloc_aligned_table Applied and fixed a bit, thanks! > Subject: [PATCH 3/5] smp: Add APIC finder and par

Re: [PATCH] SMP initialization: detection and enumeration

2020-08-12 Thread Almudena Garcia
I attach a new set of patches, fixing some errors El mar., 11 ago. 2020 a las 23:44, Almudena Garcia (< liberamenso10...@gmail.com>) escribió: > I fixed the problem manually. I expect the patch works fine. > > El mar., 11 ago. 2020 a las 23:24, Almudena Garcia (< > liberamenso10...@gmail.com>) es