Re: [PATCH] SMP initialization: detection and enumeration OFF TOPIC PRAISE

2020-08-10 Thread Joshua Branson
Almudena! Nice work on this! and Holy cow! Your English is getting fantastic! It inspires me, when I see how much you're learning on this SMP project. Keep up the good work! P.S. You might be interested in using the program git send-email. Apparently it makes it really easy to send in a pat

Re: [PATCH] SMP initialization: detection and enumeration

2020-08-10 Thread Almudena Garcia
> So don't bring them online then? The user asked for 4 CPUs, so bring up > 3 APs alongside the BSP and that's that. It's not a bad idea. Then I will fix my cpu enumeration loop to add this new condition. El mar., 11 ago. 2020 a las 2:23, Jessica Clarke () escribió: > On 11 Aug 2020, at 01:17, Al

Re: [PATCH] SMP initialization: detection and enumeration

2020-08-10 Thread Jessica Clarke
On 11 Aug 2020, at 01:17, Almudena Garcia wrote: > > > That being said, instead of hardcoding the maximum number of CPUs to > > be 256, you can just let the user choose whatever value is preferred. > > That's what Linux does. > > But this could cause coherency problems. Coherency is a very spe

Re: [PATCH] SMP initialization: detection and enumeration

2020-08-10 Thread Almudena Garcia
> That being said, instead of hardcoding the maximum number of CPUs to > be 256, you can just let the user choose whatever value is preferred. > That's what Linux does. But this could cause coherency problems. By example, if the user sets mach_ncpus=4 , and the processor has 8 cores, It can produc

Re: [PATCH] SMP initialization: detection and enumeration

2020-08-10 Thread Samuel Thibault
Almudena Garcia, le mar. 11 août 2020 01:23:49 +0200, a ecrit: > > ? git diff produces the same as format-patch, in terms of formatting > > mistakes... The disadvantage of git diff is that your patches then mix > > things altogether, see the additions to Makefrag.am. I just cannot apply > > the ser

Re: [PATCH] SMP initialization: detection and enumeration

2020-08-10 Thread Almudena Garcia
> ? git diff produces the same as format-patch, in terms of formatting > mistakes... The disadvantage of git diff is that your patches then mix > things altogether, see the additions to Makefrag.am. I just cannot apply > the series as it is. Yes, The problem is that I didn't write each file in a s

Re: [PATCH] SMP initialization: detection and enumeration

2020-08-10 Thread Samuel Thibault
Hello, Almudena Garcia, le lun. 10 août 2020 20:56:13 +0200, a ecrit: > I attach a new version of my patch, fixing some errors and following the > latest > comments about this. That looks nice overall! > This time, I've generated the files manually from "git diff", instead using > "git format-p

Re: [PATCH] SMP initialization: detection and enumeration

2020-08-10 Thread Almudena Garcia
I attach a new version of my patch, fixing some errors and following the latest comments about this. This time, I've generated the files manually from "git diff", instead using "git format-patch", so the patches could contain little format mistakes. Excuse me about this issue. El jue., 30 jul. 202