Re: [PATCH v2] linux irq: remove suer_intr from linux_action

2020-08-05 Thread Samuel Thibault
Hello, In this patch, Junling Ma, le mar. 04 août 2020 14:07:45 -0700, a ecrit: > diff --git a/linux/dev/arch/i386/kernel/irq.c > b/linux/dev/arch/i386/kernel/irq.c > index aee10462..de7d6c6a 100644 > --- a/linux/dev/arch/i386/kernel/irq.c > +++ b/linux/dev/arch/i386/kernel/irq.c > @@ -116,14 +1

Re: [PATCH] Move user_intr handling to mach side

2020-08-05 Thread Samuel Thibault
Junling Ma, le mar. 04 août 2020 18:21:21 -0700, a ecrit: > >> +__disable_irq (irqtab.irq[id]); > > > > I'd say add a struct irqdev * in the user_intr_t, so you don't have to > > hardcode irqtab. Also, no need to keep it inside splhigh. > > Sure we can keep a pointer inside user_intr_t. > Bu

Re: [PATCH] user_intr: a lock to protect main_intr_queue

2020-08-05 Thread Samuel Thibault
Junling Ma, le mar. 04 août 2020 17:59:57 -0700, a ecrit: > > On Aug 4, 2020, at 5:30 PM, Samuel Thibault wrote: > > > > Junling Ma, le mar. 04 août 2020 17:08:03 -0700, a ecrit: > static user_intr_t * > search_intr (struct irqdev *dev, ipc_port_t dst_port) > { > user_intr_t