Re: [PATCH] SMP initialization: detection and enumeration

2020-07-27 Thread Jessica Clarke
On 28 Jul 2020, at 00:44, Samuel Thibault wrote: > Almudena Garcia, le lun. 27 juil. 2020 21:15:10 +0200, a ecrit: >> [if [ $mach_ncpus -gt 1 ]; then] >> AC_DEFINE([MULTIPROCESSOR], [1], [set things up for a multiprocessor]) >> + AC_DEFINE_UNQUOTED([NCPUS], [255], [number of CPUs]) > > Perhaps

Re: [PATCH 2/2] libmachdev: Introduce startup notification for clean rumpdisk shutdown

2020-07-27 Thread Samuel Thibault
Damien Zammit, le dim. 26 juil. 2020 17:37:21 +1000, a ecrit: > @@ -183,7 +185,16 @@ S_i386_io_perm_create (mach_port_t master_port, >return i386_io_perm_create (_hurd_device_master, from, to, io_perm); > } > > -/* This is fraud */ > +kern_return_t > +trivfs_S_fsys_init (struct trivfs_contro

Re: [PATCH 1/2] libdiskfs: Refactor fsys_startup invokation for bootstrapping

2020-07-27 Thread Samuel Thibault
Damien Zammit, le dim. 26 juil. 2020 17:37:20 +1000, a ecrit: > diff --git a/libdiskfs/init-startup.c b/libdiskfs/init-startup.c > index a2e3638d..d28a49a1 100644 > --- a/libdiskfs/init-startup.c > +++ b/libdiskfs/init-startup.c Applied that part (with just an if inversion to make it simpler to re

Re: [PATCH 1/2] libdiskfs: Refactor fsys_startup invokation for bootstrapping

2020-07-27 Thread Samuel Thibault
Damien Zammit, le dim. 26 juil. 2020 17:37:20 +1000, a ecrit: > --- > libdiskfs/boot-start.c | 11 +++ > libdiskfs/init-startup.c | 64 +--- > 2 files changed, 52 insertions(+), 23 deletions(-) > > diff --git a/libdiskfs/boot-start.c b/libdiskfs/boot-star

Re: [PATCH] SMP initialization: detection and enumeration

2020-07-27 Thread Samuel Thibault
Hello, Thanks for your work, we're getting closer! Almudena Garcia, le lun. 27 juil. 2020 21:15:10 +0200, a ecrit: > @@ -170,6 +172,14 @@ void machine_init(void) > linux_init(); > #endif > > +#if NCPUS > 1 > + int smp_success = smp_init(); > + > + if(smp_success != 0) { > +

Re: [PATCH] SMP initialization: detection and enumeration

2020-07-27 Thread Almudena Garcia
New patches collection, fixing the formatting El lun., 20 jul. 2020 a las 0:35, Almudena Garcia (< liberamenso10...@gmail.com>) escribió: > Here are the fixed patches. Check this and advise me if there are any > errors. > > El dom., 19 jul. 2020 a las 23:53, Almudena Garcia (< > liberamenso10...@