Hello,
Almudena Garcia, le dim. 12 mai 2019 00:29:35 +0200, a ecrit:
> My project Hurd SMP (where I try to build SMP support in Hurd) has been
> awarded
> in the spanish contest "Concurso Universitario de Software Libre". This
> contest
> award to the best free software projects developed by stu
Hi all:
My project Hurd SMP (where I try to build SMP support in Hurd) has been
awarded in the spanish contest "Concurso Universitario de Software Libre".
This contest award to the best free software projects developed by students.
The project has received the award to the best system related pro
Joan Lledó, le sam. 11 mai 2019 11:32:02 +0200, a ecrit:
> * lwip/lwip-util.c:
> * EINVAL was never being returned.
> * Return error code for tcpip_callback() as errno.
Applied, thanks!
Samuel
Here's the patch with your suggestions.
* lwip/lwip-util.c:
* EINVAL was never being returned.
* Return error code for tcpip_callback() as errno.
---
lwip/lwip-util.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/lwip/lwip-util.c b/lwip/lwip-util.c
index 4f632185..61f3194a 100644
--- a/lwip/
Joan Lledó, le sam. 11 mai 2019 10:47:55 +0200, a ecrit:
> Missatge de Samuel Thibault del dia ds., 11
> de maig 2019 a les 10:40:
> > It's just like malloc() returning ENOMEM :)
>
> It seems the best option, but I didn't find it in the POSIX entry for
> ioctl().
ioctl() is an excessively versat
Missatge de Samuel Thibault del dia ds., 11
de maig 2019 a les 10:40:
> It's just like malloc() returning ENOMEM :)
It seems the best option, but I didn't find it in the POSIX entry for
ioctl(). OK, I'll return ENOMEM then.
Joan Lledó, le sam. 11 mai 2019 10:30:39 +0200, a ecrit:
> @@ -357,9 +357,9 @@ configure_device (struct netif *netif, uint32_t addr,
> uint32_t netmask,
>arg->addr6 = addr6;
>arg->addr6_prefix_len = addr6_prefix_len;
>err = tcpip_callback (update_if, arg);
> - if (err)
Joan Lledó, le sam. 11 mai 2019 10:30:38 +0200, a ecrit:
> The only error possible in this call is ERR_MEM, when the system runs out of
> memory. This operation is the result of calling ioctl() from the user side,
> and I don't know what errno return to glibc in this case.
It's just like malloc(
* lwip/lwip-util.c:
* EINVAL was never being returned.
* Return EAGAIN when tcpip_callback() fails.
---
lwip/lwip-util.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lwip/lwip-util.c b/lwip/lwip-util.c
index 4f632185..235232ce 100644
--- a/lwip/lwip-u
Hi,
For this case, the callback update_if() doesn't set any error, so there's no
need to propagate it.
On the other hand, tcpip_callback() doesn't return an errno, it returns an
internal lwip error code. The only error possible in this call is ERR_MEM, when
the system runs out of memory. This
11 matches
Mail list logo
