Re: Reverting "libdiskfs: Shutdown pagers on startup_dosync."

2018-01-17 Thread Samuel Thibault
Justus Winter, on mer. 17 janv. 2018 11:55:29 +0100, wrote: > But at some point we make the image read-only, and at that point there > are still other servers running. If other servers are running, they use > some pagers. Iirc if a library is in use (i.e. a pager is in use) at > system shutdown,

Re: Reverting "libdiskfs: Shutdown pagers on startup_dosync."

2018-01-17 Thread Justus Winter
Samuel Thibault writes: > Justus Winter, on mer. 17 janv. 2018 11:36:00 +0100, wrote: >> I'm still convinced that shutting down the servers is the right thing to >> do. The alternative is that the filesystem goes away with an unclean >> disk image. > > It's not unclean since after inhibiting mor

Re: Reverting "libdiskfs: Shutdown pagers on startup_dosync."

2018-01-17 Thread Samuel Thibault
Justus Winter, on mer. 17 janv. 2018 11:36:00 +0100, wrote: > Samuel Thibault writes: > > I don't know if the pager actually supports the operation that we want? > > (just crashing clients) > > Yes it does. Well, apparently it didn't behave that way :) > I'm still convinced that shutting down t

Re: Reverting "libdiskfs: Shutdown pagers on startup_dosync."

2018-01-17 Thread Justus Winter
Samuel Thibault writes: > Hello Justus, > > I had to revert your commit: Yes, I saw that :/ > “ > commit f05b6bae5cbdf3c221eba05987dea7ab14e6524f > Author: Samuel Thibault > Date: Mon Jan 15 22:00:11 2018 +0100 > > Revert "libdiskfs: Shutdown pagers on startup_dosync." > > This