gsync/libihash hash function

2016-11-04 Thread Brent W. Baccala
Hi - My recent foray into gsync left me thinking a bit about its hash function: #define MIX2_LL(x, y) x) << 5) | ((x) >> 27)) ^ (y)) which seems a bit weak. The result of gsync_key_hash is then taken modulo GSYNC_NBUCKETS, which is currently 512. libihash has a similar issue. It seems t

Re: kernel panic in gsync_wait

2016-11-04 Thread Brent W. Baccala
On Fri, Nov 4, 2016 at 12:00 AM, Samuel Thibault wrote: > Brent W. Baccala, on Thu 03 Nov 2016 15:51:04 -1000, wrote: > > I see... so there must be fallback code (option 2 on my list); I just > haven't > > found it. > > > > Where is KERN_FAILURE handled in user space? > > It's not. Gsync_wait jus

Re: rpctrace man page

2016-11-04 Thread Ludovic Courtès
Hello! Thanks for taking care of the manual! Just a very very partial review… "Brent W. Baccala" skribis: > +@node rpctrace > +@section rpctrace The convention would be to call this section “Invoking rpctrace”, so: @node Invoking rpctrace @section Invoking @command{rpctrace} > +@example

Re: kernel panic in gsync_wait

2016-11-04 Thread Samuel Thibault
Brent W. Baccala, on Thu 03 Nov 2016 15:51:04 -1000, wrote: > I see... so there must be fallback code (option 2 on my list); I just haven't > found it. > > Where is KERN_FAILURE handled in user space? It's not. Gsync_wait just returns, and the while loop just tries to take the lock again. Samuel