As promised, here's the patch to avoid the aforementioned alloca bugs.
It's a bit of an overkill, imo, but it does support ridiculously long
command-line arguments =D
For most practical issues, the fix posted in
http://lists.gnu.org/archive/html/bug-hurd/2016-03/msg00086.html
should be enough.
d
Hi,
Here are the stack traces:
=> LD_DEBUG=bindings
On Tue, Mar 15, 2016 at 10:30:07PM +0100, Samuel Thibault wrote:
> Hello,
>
> Diego Nieto Cid, on Sun 13 Mar 2016 18:28:46 -0300, wrote:
> > => 0x0001052b <_dl_start_profile+235>: mov%eax,-0x24c(%ebp)
> > 0x00010531 <_dl_start_prof
Hello,
Diego Nieto Cid, on Sun 13 Mar 2016 18:28:46 -0300, wrote:
> => 0x0001052b <_dl_start_profile+235>: mov%eax,-0x24c(%ebp)
> 0x00010531 <_dl_start_profile+241>: lea-0x224(%ebp),%eax
>
> => 0x00017812 <__strerror_r+194>: pushl (%eax,%edi,4)
> 0x00017815 <__strer
Quoting Flavio Cruz (2016-03-14 21:22:34)
> * Makefile.am: Set AM_YFLAGS to -d to generate parser.h. Add parser.h to
> CLEANFILES and include parser.h as a dependency of lexxer.c.
> * lexxer.l: Declare yyerror here.
> * parser.h: Remove file since yacc will generate the same content
> automatically
Quoting Samuel Thibault (2016-03-15 18:30:16)
> Justus Winter, on Tue 15 Mar 2016 18:10:18 +0100, wrote:
> > Quoting Samuel Thibault (2016-03-15 17:31:53)
> > > Justus Winter, on Tue 15 Mar 2016 14:39:00 +0100, wrote:
> > > > Quoting Agustina Arzille (2016-03-15 14:11:27)
> > > > > Hello, everyone.
On 2016-03-15 15:02, Samuel Thibault wrote:
Agustina Arzille, on Tue 15 Mar 2016 14:57:19 -0300, wrote:
That's not what I meant. Stack overflow is clearly very unlikely, if
not
impossible. What I meant about 'dangerous' is the fact that alloca is
being
used inside the list of arguments of a fu
Agustina Arzille, on Tue 15 Mar 2016 14:57:19 -0300, wrote:
> On 2016-03-15 13:31, Samuel Thibault wrote:
> >Justus Winter, on Tue 15 Mar 2016 14:39:00 +0100, wrote:
> >>Quoting Agustina Arzille (2016-03-15 14:11:27)
> >>> Hello, everyone.
> >>>
> >>> I was browsing some gnumach source files, and n
Hello, Samuel.
On 2016-03-15 13:31, Samuel Thibault wrote:
Justus Winter, on Tue 15 Mar 2016 14:39:00 +0100, wrote:
Quoting Agustina Arzille (2016-03-15 14:11:27)
> Hello, everyone.
>
> I was browsing some gnumach source files, and noticed some dangerous use
> of the gcc builtin 'alloca'. In th
Justus Winter, on Tue 15 Mar 2016 18:10:18 +0100, wrote:
> Quoting Samuel Thibault (2016-03-15 17:31:53)
> > Justus Winter, on Tue 15 Mar 2016 14:39:00 +0100, wrote:
> > > Quoting Agustina Arzille (2016-03-15 14:11:27)
> > > > Hello, everyone.
> > > >
> > > > I was browsing some gnumach source fil
Quoting Samuel Thibault (2016-03-15 17:31:53)
> Justus Winter, on Tue 15 Mar 2016 14:39:00 +0100, wrote:
> > Quoting Agustina Arzille (2016-03-15 14:11:27)
> > > Hello, everyone.
> > >
> > > I was browsing some gnumach source files, and noticed some dangerous use
> > > of the gcc builtin 'alloca'.
Justus Winter, on Tue 15 Mar 2016 14:39:00 +0100, wrote:
> Quoting Agustina Arzille (2016-03-15 14:11:27)
> > Hello, everyone.
> >
> > I was browsing some gnumach source files, and noticed some dangerous use
> > of the gcc builtin 'alloca'. In the file kern/bootstrap.c, lines 212 and
> > 228, we h
Quoting Agustina Arzille (2016-03-15 15:44:13)
> > Good catch. However, alloca is dangerous even if used correctly, and
> > is best be avoided. Would you be so kind to prepare a patch to that
> > end?
> >
> > Thanks,
> > Justus
>
> Sure. I will cook up a patch when I get home. Right now, the
>
Hello, Justus,
On 2016-03-15 10:39, Justus Winter wrote:
Hi,
Quoting Agustina Arzille (2016-03-15 14:11:27)
Hello, everyone.
I was browsing some gnumach source files, and noticed some dangerous
use
of the gcc builtin 'alloca'. In the file kern/bootstrap.c, lines 212
and
228, we have the fo
Hi,
Quoting Agustina Arzille (2016-03-15 14:11:27)
> Hello, everyone.
>
> I was browsing some gnumach source files, and noticed some dangerous use
> of the gcc builtin 'alloca'. In the file kern/bootstrap.c, lines 212 and
> 228, we have the following statement:
>
> memcpy (alloca (len), ...)
Go
Hello, everyone.
I was browsing some gnumach source files, and noticed some dangerous use
of the gcc builtin 'alloca'. In the file kern/bootstrap.c, lines 212 and
228, we have the following statement:
memcpy (alloca (len), ...)
This is dangerous because alloca works by adjusting the stack point
* Makefile.am: Set AM_YFLAGS to -d to generate parser.h. Add parser.h to
CLEANFILES and include parser.h as a dependency of lexxer.c.
* lexxer.l: Declare yyerror here.
* parser.h: Remove file since yacc will generate the same content
automatically.
---
Makefile.am | 6 -
lexxer.l| 2 ++
16 matches
Mail list logo
