Re: [PATCH] fix compiler warning in hurd/fstests

2015-12-31 Thread Samuel Thibault
Applied, thanks!

Re: [PATCH] Drop OTHERLIBS and use LDLIBS exclusively

2015-12-31 Thread Samuel Thibault
Applied, thanks!

[PATCH] fix some compiler warnings in gnumach

2015-12-31 Thread Flavio Cruz
Fix some compiler warnings. * linux/dev/glue/block.c (out): Cast to device_t. * linux/dev/glue/block.c (device_get_status): Cast to struct disk_params *. * linux/dev/init/main.c (alloc_contig_mem): Initialize addr and cast return value to void *. * i386/i386/phys.c (pmap_copy_page): Initialize sr

Re: [PATCH] Drop OTHERLIBS and use LDLIBS exclusively

2015-12-31 Thread Samuel Thibault
Flavio Cruz, on Thu 31 Dec 2015 17:49:25 +0100, wrote: > When cross-compiling, OTHERLIBS magically turns -lpthread into the path > to the host libpthread.so file, resulting in build issues. LDLIBS does > not suffer from this problem and it seems that is already being used in > other Makefiles. This

[PATCH] Drop OTHERLIBS and use LDLIBS exclusively

2015-12-31 Thread Flavio Cruz
When cross-compiling, OTHERLIBS magically turns -lpthread into the path to the host libpthread.so file, resulting in build issues. LDLIBS does not suffer from this problem and it seems that is already being used in other Makefiles. This patch removes OTHERLIBS entirely from the build system. ---

[PATCH] fix compiler warning in hurd/fstests

2015-12-31 Thread Flavio Cruz
--- * fstests/fstests.c (main): Only declare 'root' when HURDISH_TESTS is defined. diff --git a/fstests/fstests.c b/fstests/fstests.c index c652a70..c71b13a 100644 --- a/fstests/fstests.c +++ b/fstests/fstests.c @@ -42,8 +42,8 @@ int check_refs (mach_port_t port) /* To call from gdb */ int main

Re: [PATCH] Use DEVICE_IMPORTS to include libports/ports.h

2015-12-31 Thread Samuel Thibault
Flavio Cruz, on Thu 31 Dec 2015 16:45:51 +0100, wrote: > Agreed. I think only devnode should include it in mig-mutate.h. For > term, only some stubs are including mig-mutate.h. For trans, there's no > mig-mutate.h at all. Here's the modified patch. Applied, thanks! Samuel

Re: [PATCH] Use DEVICE_IMPORTS to include libports/ports.h

2015-12-31 Thread Samuel Thibault
Justus Winter, on Thu 31 Dec 2015 16:28:14 +0100, wrote: > Quoting Samuel Thibault (2015-12-31 16:11:30) > > Flavio Cruz, on Thu 31 Dec 2015 15:56:31 +0100, wrote: > > > This fixes three compiler warnings about ports_payload_get_name. > > > > > > * devnode/Makefile: Define DEVICE_IMPORTS. > > > *

Re: [PATCH] Use DEVICE_IMPORTS to include libports/ports.h

2015-12-31 Thread Flavio Cruz
On Thu, Dec 31, 2015 at 04:28:14PM +0100, Justus Winter wrote: > Quoting Samuel Thibault (2015-12-31 16:11:30) > > Flavio Cruz, on Thu 31 Dec 2015 15:56:31 +0100, wrote: > > > This fixes three compiler warnings about ports_payload_get_name. > > > > > > * devnode/Makefile: Define DEVICE_IMPORTS. >

Re: [PATCH] Use DEVICE_IMPORTS to include libports/ports.h

2015-12-31 Thread Justus Winter
Quoting Samuel Thibault (2015-12-31 16:11:30) > Flavio Cruz, on Thu 31 Dec 2015 15:56:31 +0100, wrote: > > This fixes three compiler warnings about ports_payload_get_name. > > > > * devnode/Makefile: Define DEVICE_IMPORTS. > > * term/Makefile: Likewise. > > * trans/Makefile: Likewise. > > Why not

Re: [PATCH] Define IO_OUTTRAN so that term_on_pty returns a mach_port_t

2015-12-31 Thread Samuel Thibault
Applied, thanks! Samuel

[PATCH] Define IO_OUTTRAN so that term_on_pty returns a mach_port_t

2015-12-31 Thread Flavio Cruz
* libtrivfs/mig-decls.h: Implement trivfs_convert_to_port. * term/mig-mutate.h: Define IO_OUTTRAN. --- diff --git a/libtrivfs/mig-decls.h b/libtrivfs/mig-decls.h index 230af23..f3afd5a 100644 --- a/libtrivfs/mig-decls.h +++ b/libtrivfs/mig-decls.h @@ -75,6 +75,12 @@ trivfs_end_using_protid (stru

Re: [PATCH] Use DEVICE_IMPORTS to include libports/ports.h

2015-12-31 Thread Samuel Thibault
Flavio Cruz, on Thu 31 Dec 2015 15:56:31 +0100, wrote: > This fixes three compiler warnings about ports_payload_get_name. > > * devnode/Makefile: Define DEVICE_IMPORTS. > * term/Makefile: Likewise. > * trans/Makefile: Likewise. Why not adding them to the corresponding mig-mutate.h? Samuel

[PATCH] Use DEVICE_IMPORTS to include libports/ports.h

2015-12-31 Thread Flavio Cruz
This fixes three compiler warnings about ports_payload_get_name. * devnode/Makefile: Define DEVICE_IMPORTS. * term/Makefile: Likewise. * trans/Makefile: Likewise. --- diff --git a/devnode/Makefile b/devnode/Makefile index 0964f8d..e46e4fd 100644 --- a/devnode/Makefile +++ b/devnode/Makefile @@ -

Re: [PATCH] Cast kernel server call arguments to the correct type when mach_port_t and ipc_port_t are used interchangeably

2015-12-31 Thread Flavio Cruz
On Thu, Dec 31, 2015 at 03:11:44PM +0100, Justus Winter wrote: > Quoting Flavio Cruz (2015-12-30 18:03:58) > > This fixes a warning when compiling the mig generated file > > gnumach/kern/mach4.server.c. Here, an ipc_port_t* is passed to a > > function that expects a mach_port_t* (In0P->object). Sin

Re: [PATCH] Cast kernel server call arguments to the correct type when mach_port_t and ipc_port_t are used interchangeably

2015-12-31 Thread Justus Winter
Quoting Flavio Cruz (2015-12-30 18:03:58) > This fixes a warning when compiling the mig generated file > gnumach/kern/mach4.server.c. Here, an ipc_port_t* is passed to a > function that expects a mach_port_t* (In0P->object). Since mig uses > mach_port_t and ipc_port_t interchangeably in kernel inte