Re: [PATCH] utils/mount: canonicalize mountpoints

2014-11-20 Thread Samuel Thibault
Hello, Could you try the patch I have just pushed? I believe it should be doing the right thing. Samuel

Re: [PATCH] trans/mtab: avoid firmlink loops

2014-11-20 Thread Samuel Thibault
Justus Winter, le Sun 05 Oct 2014 13:26:42 +0200, a écrit : > * trans/mtab.c (struct mtab): Add a hash table to keep track of seen > ports. > (mtab_mark_as_seen): New function that records the identity port of a > given node in the hash table and reports whether it has been there > before. > (mtab_

Re: [PATCH gnumach] Correct GCC's -Wformat-security issues

2014-11-20 Thread Samuel Thibault
Applied, thanks!

Re: [PATCH gnumach 2/2] include: add X_IMPORTS to ipc definitions

2014-11-20 Thread Samuel Thibault
Justus Winter, le Wed 12 Nov 2014 16:49:09 +0100, a écrit : > This makes it possible to inject imports. Ack. > * include/mach/gnumach.defs: Make it possible to inject imports. > * include/mach/mach.defs: Likewise. > * include/mach/mach_host.defs: Likewise. > --- > include/mach/gnumach.defs | 4

Re: [PATCH gnumach 1/2] kern: provide notifications about new tasks

2014-11-20 Thread Samuel Thibault
Justus Winter, le Wed 12 Nov 2014 16:49:08 +0100, a écrit : > +kern_return_t > +register_new_task_notification( > + const host_t host, > + ipc_port_t notification) > +{ > + if (host == HOST_NULL) > + return KERN_INVALID_HOST; > + > + if (new_task_notification != NULL) >

Re: [PATCH hurd 8/9] boot: implement pseudo-time device

2014-11-20 Thread Samuel Thibault
Justus Winter, le Fri 07 Nov 2014 17:32:01 +0100, a écrit : > * boot/boot.c (pseudo_time): New variable. > (main): Allocate port `pseudo_time'. > (ds_device_open): Give out `pseudo_time'. > (ds_device_map): Emulate Mach-style `Mapped Time'. Ack. > --- > boot/boot.c | 38 +

Re: [PATCH hurd 7/9] boot: support ds_device_get_status with flavor DEV_GET_RECORDS

2014-11-20 Thread Samuel Thibault
Justus Winter, le Fri 07 Nov 2014 17:32:00 +0100, a écrit : > * boot/boot.c (ds_device_get_status): Support flavor DEV_GET_RECORDS. Ack. > --- > boot/boot.c | 33 + > 1 file changed, 21 insertions(+), 12 deletions(-) > > diff --git a/boot/boot.c b/boot/boot.c > i

Re: [PATCH hurd 5/9] boot: remove unused function `boot_script_read_file'

2014-11-20 Thread Samuel Thibault
Justus Winter, le Fri 07 Nov 2014 17:31:58 +0100, a écrit : > The unused function `boot_script_read_file' requires access to the > default pager, which is privileged. Ack. > * boot/boot.c (defpager): Remove now unused variable. > (boot_script_read_file): Remove unused function. > (main): Do not a

Re: [PATCH hurd 3/9] startup: also open `console' for reading

2014-11-20 Thread Samuel Thibault
Justus Winter, le Fri 07 Nov 2014 17:31:56 +0100, a écrit : > * startup/startup.c (main): Also open `console' for reading. Ack. > --- > startup/startup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/startup/startup.c b/startup/startup.c > index ff58270..e177075 10064

Re: [PATCH hurd 2/9] proc: gracefully handle failure to increase priority

2014-11-20 Thread Samuel Thibault
Justus Winter, le Fri 07 Nov 2014 17:31:55 +0100, a écrit : > * proc/main.c (increase_priority): New function. > (main): Move code increasing the proc servers priority to a new > function and handle errors gracefully. Ack. > --- > proc/main.c | 44 >

Re: [PATCH hurd 1/9] Makeconf: handle the gnumach protocol

2014-11-20 Thread Samuel Thibault
Justus Winter, le Fri 07 Nov 2014 17:31:54 +0100, a écrit : > * Makeconf (mach_defs_names): Add `gnumach'. Ack. > --- > Makeconf | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Makeconf b/Makeconf > index 32eec13..f0d3fe3 100644 > --- a/Makeconf > +++ b/Makeconf > @@

Re: [PATCH 4/8] init: add a minimalist init program

2014-11-20 Thread Samuel Thibault
Justus Winter, le Wed 03 Sep 2014 14:33:12 +0200, a écrit : > +# This is necessary to make stat / return the correct device ids. > +# Work around a race condition (probably in the root translator). > +for i in `seq 1 10` ; do : ; done Please at least put XXX here, so it hopefully will get inve

Re: Release process & rolling new releases

2014-11-20 Thread Justus Winter
Quoting Samuel Thibault (2014-11-20 00:59:23) > I'm however wondering: I don't see much reviewing being done apart > from mine. It would help if some people could spend time on reviewing > patches. I'm not saying taking responsibility for the commit step or > anything, but just proofreading the s

One-line build-test from busybox statically built segfaults on GNU/Hurd

2014-11-20 Thread Svante Signell
Hi, from the debian-hurd IRC, with inlined comments: (11:03:58) mjt: hello. it looks like hurd-i386 is the only arch where my one-line build-test program fails -- see https://buildd.debian.org/status/package.php?p=busybox Checking if libc can produce working static binaries echo 'int main(void) {