Re: [PATCH 8/8] include: add a payload-aware intran mutator for device_t

Ack. Justus Winter, le Thu 18 Sep 2014 15:22:50 +0200, a écrit : > * include/device/device_types.defs (device_t): Add a payload-aware > intran mutator. > --- > include/device/device_types.defs | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/device/device_types.defs > b/inclu

Re: [PATCH 7/8] include: add a payload-aware intran mutator for notify_port_t

Ack. Justus Winter, le Thu 18 Sep 2014 15:22:49 +0200, a écrit : > * include/mach/notify.defs (notify_port_t): Add a payload-aware intran > mutator. > --- > include/mach/notify.defs | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/mach/notify.defs b/include/mach/notify.defs >

Re: [PATCH 6/8] include: add a payload-aware intran mutator for memory_object_t

Ack. Justus Winter, le Thu 18 Sep 2014 15:22:48 +0200, a écrit : > * include/mach/mach_types.defs (memory_object_t): Add a payload-aware > intran mutator. > * include/mach/memory_object.defs: Likewise in the inlined type > declarations. > --- > include/mach/mach_types.defs| 3 +++ > include/

Re: [PATCH 5/8] ipc: provide the protected payload in ipc_kmsg_copyout_header

Ack. Justus Winter, le Thu 18 Sep 2014 15:22:47 +0200, a écrit : > * ipc/ipc_kmsg.c (ipc_kmsg_copyout_header): If a protected payload is > set for the destination port, provide it in msgh_protected_payload. > * ipc/mach_msg.c (mach_msg_trap): Likewise in the fast paths. > * doc/mach.texi (Message

Re: [PATCH 3/8] include: add msgh_protected_payload to mach_msg_header_t

Ack. Justus Winter, le Thu 18 Sep 2014 15:22:45 +0200, a écrit : > * include/mach/message.h (mach_msg_header_t): Add > msgh_protected_payload as a union with msgh_local_port. > * doc/mach.texi (Message Format): Document msgh_protected_payload. > --- > doc/mach.texi | 9 + > inc

Re: [PATCH 4/8] include: define MACH_MSG_TYPE_PROTECTED_PAYLOAD

Ack. Justus Winter, le Thu 18 Sep 2014 15:22:46 +0200, a écrit : > * include/mach/message.h: Define MACH_MSG_TYPE_PROTECTED_PAYLOAD. > (MACH_MSG_TYPE_LAST): Adjust accordingly. > * doc/mach.texi (Message Format): Document > MACH_MSG_TYPE_PROTECTED_PAYLOAD. > --- > doc/mach.texi | 6 +

Re: [PATCH 2/8] ipc: implement mach_port_{set,clear}_protected_payload

Ack. Justus Winter, le Thu 18 Sep 2014 15:22:44 +0200, a écrit : > * include/mach/mach_port.defs: Add mach_port_{set,clear}_protected_payload. > * ipc/mach_port.c: Implement mach_port_{set,clear}_protected_payload. > * doc/mach.texi (Receive Rights): Document > mach_port_{set,clear}_protected_payl

Re: [PATCH 1/8] ipc: add protected payload

Justus Winter, le Thu 18 Sep 2014 15:22:43 +0200, a écrit : > Add a field ip_protected_payload and a flag ip_has_protected_payload > to struct ipc_port. > > Clear the protected payload when a receive port is moved from one ipc > space to another. This is done to retain the old behavior of > mach_

Re: [PATCH 5/5] ipc: provide the protected payload in ipc_kmsg_copyout_header

Justus Winter, le Thu 18 Sep 2014 15:22:10 +0200, a écrit : > All the userspace code I have written operates under the assumption > that the protected payloads are an optimization. This makes it > possible to use the binaries on older kernels and provides an easy and > robust upgrade path. Right.

Re: [PATCH 7/7] procfs: provide magic retry response for /proc/self

Hello, Justus Winter, le Mon 22 Sep 2014 11:38:44 +0200, a écrit : > diff --git a/hurd/hurd_types.h b/hurd/hurd_types.h > index 4341177..f22816d 100644 > --- a/hurd/hurd_types.h > +++ b/hurd/hurd_types.h > @@ -114,6 +114,9 @@ enum retry_type > as for FS_RETRY_NORMAL. > >

Re: [PATCH] utils/mount: canonicalize mountpoints

Getting back to this old thread so we may get pbuilder to work... Samuel Thibault, le Sat 14 Jun 2014 22:44:56 +0200, a écrit : > Gabriele Giacone, le Thu 05 Jun 2014 00:34:45 +0200, a écrit : > > * utils/mount.c (main): realpath mountpoint. > > * utils/umount.c (do_umount): Likewise. > > Mmm, bu

Re: [PATCH gnumach 3/3] ipc: use fast modulo operation in local hash table

Justus Winter, le Tue 30 Sep 2014 16:16:29 +0200, a écrit : > Hm, where would you put that? The size tables (ipc_table_entries and > ipc_table_dnrequests) are filled once by ipc_table_fill. Ah, right, so it's powers of two by construction, good. Then ack. Samuel

Re: [PATCH gnumach 3/3] ipc: use fast modulo operation in local hash table

Quoting Samuel Thibault (2014-09-30 14:23:34) > Justus Winter, le Tue 30 Sep 2014 14:06:18 +0200, a écrit : > > @@ -45,6 +45,8 @@ > > * an ipc_table_size structure. These structures must > > * be elements of an array, ipc_table_entries. > > * > > + * Every its_size value must must be a

Re: [PATCH gnumach 3/3] ipc: use fast modulo operation in local hash table

Justus Winter, le Tue 30 Sep 2014 14:06:18 +0200, a écrit : > @@ -45,6 +45,8 @@ > * an ipc_table_size structure. These structures must > * be elements of an array, ipc_table_entries. > * > + * Every its_size value must must be a power of two. Perhaps add a runtime check which makes su

Re: [PATCH gnumach 2/3] kern: silence compiler warning about uninitialized variable

Justus Winter, le Tue 30 Sep 2014 14:06:17 +0200, a écrit : > * kern/slab.c (kmem_cache_compute_sizes): Initialize optimal_size and > assert that a size is selected. Ack. > --- > kern/slab.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kern/slab.c b/kern/slab.c > i

Re: [PATCH gnumach 1/3] kern: fix type of recompute_priorities

Justus Winter, le Tue 30 Sep 2014 14:06:16 +0200, a écrit : > * kern/sched_prim.c (recompute_priorities): Fix type. > * kern/sched_prim.h (recompute_priorities): Likewise. Ack. > --- > kern/sched_prim.c | 2 +- > kern/sched_prim.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > d

[PATCH gnumach 1/3] kern: fix type of recompute_priorities

* kern/sched_prim.c (recompute_priorities): Fix type. * kern/sched_prim.h (recompute_priorities): Likewise. --- kern/sched_prim.c | 2 +- kern/sched_prim.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kern/sched_prim.c b/kern/sched_prim.c index 1d2e14e..66eb9c9 100644 ---

[PATCH gnumach 3/3] ipc: use fast modulo operation in local hash table

* ipc/ipc_table.h: Document that table sizes must be powers of two. * ipc/ipc_hash.c (IH_LOCAL_HASH): Use fast modulo operation. --- ipc/ipc_hash.c | 2 +- ipc/ipc_table.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/ipc/ipc_hash.c b/ipc/ipc_hash.c index 8285717..c2c6d6e

[PATCH gnumach 2/3] kern: silence compiler warning about uninitialized variable

* kern/slab.c (kmem_cache_compute_sizes): Initialize optimal_size and assert that a size is selected. --- kern/slab.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kern/slab.c b/kern/slab.c index e8451a8..19ebfed 100644 --- a/kern/slab.c +++ b/kern/slab.c @@ -702,7 +702,7 @