Re: [PATCH] nscd: Remove unused typedef and variable.

2014-06-23 Thread Manolis Ragkousis
Tested on Hurd. Manolis

Re: [PATCH 1/8] ext2fs: use correct type for block numbers

2014-06-23 Thread Samuel Thibault
Justus Winter, le Fri 20 Jun 2014 19:15:04 +0200, a écrit : > * ext2fs/dir.c (count_dirents): Use block_t for nb. > (diskfs_get_directs): Likewise for blkno, nblks. Ack. > --- > ext2fs/dir.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ext2fs/dir.c b/ext2fs/dir

Re: [PATCH 2/8] ext2fs: use a seperate lock to protect nodehash

2014-06-23 Thread Justus Winter
Quoting Justus Winter (2014-06-20 19:15:05) > Previously, ext2fs used diskfs_node_refcnt_lock to serialize access to > the nodehash. With this patch applied, I see filesystem corruptions. This patch could still be ok, as it might just expose some other problem. As Richard suggested I am using gi

Re: [PATCH] libdiskfs: fix deadlock

2014-06-23 Thread Samuel Thibault
Justus Winter, le Sun 22 Jun 2014 15:45:42 +0200, a écrit : > Previously, libdiskfs would deadlock on contention on renamedirlock > due to the lock being taken spuriously. > > Found using fsstress from the Linux Test Project. Wow, good spot! Ack! > * libdiskfs/dir-rename.c (diskfs_S_dir_rename)

Re: [PATCH] nscd: Remove unused typedef and variable.

2014-06-23 Thread Ludovic Courtès
Ondřej Bílka skribis: > On Sun, Jun 22, 2014 at 11:55:43AM +0200, Ludovic Courtès wrote: >> The attached patch removed the unused ‘thread_info_t’ typedef and the >> ‘thread_info’ variable from nscd.c. The former conflicts with a GNU Mach >> typedef, and the latter conflicts with a GNU Mach funct