Re: [PATCH] utils/mount: canonicalize mountpoints

2014-06-14 Thread Samuel Thibault
Gabriele Giacone, le Sun 15 Jun 2014 02:23:49 +0200, a écrit : > On Sun, Jun 15, 2014 at 1:59 AM, Samuel Thibault > wrote: > > Gabriele Giacone, le Sun 15 Jun 2014 01:28:06 +0200, a écrit : > >> ... this one would fix malformed mount/umount input paths (another > >> source. Any else? raw settrans)

Re: [PATCH] utils/mount: canonicalize mountpoints

2014-06-14 Thread Gabriele Giacone
On Sun, Jun 15, 2014 at 1:59 AM, Samuel Thibault wrote: > Gabriele Giacone, le Sun 15 Jun 2014 01:28:06 +0200, a écrit : >> ... this one would fix malformed mount/umount input paths (another >> source. Any else? raw settrans). It would make first and last hunks in >> pbuilder.diff [0] useless. >>

Re: [PATCH] utils/mount: canonicalize mountpoints

2014-06-14 Thread Samuel Thibault
Gabriele Giacone, le Sun 15 Jun 2014 01:28:06 +0200, a écrit : > > Mmm, but sutils/fstab.c already does apply realpath, doesn't it? I see > > it doing it in fstab_find. > > In fstab_find, it just helps finding paths in fstab so that it looks > for both input one as-is and input one realpath'ed. I

Re: [PATCH] utils/mount: canonicalize mountpoints

2014-06-14 Thread Gabriele Giacone
On Sat, Jun 14, 2014 at 10:44 PM, Samuel Thibault wrote: > Gabriele Giacone, le Thu 05 Jun 2014 00:34:45 +0200, a écrit : >> * utils/mount.c (main): realpath mountpoint. >> * utils/umount.c (do_umount): Likewise. > > Mmm, but sutils/fstab.c already does apply realpath, doesn't it? I see > it doin

Re: [PATCH 4/4] utils/settrans: implement settrans --start

2014-06-14 Thread Samuel Thibault
Justus Winter, le Sat 14 Jun 2014 22:54:50 +0200, a écrit : > Quoting Samuel Thibault (2014-06-14 21:48:09) > > Hello, > > > > Justus Winter, le Wed 11 Jun 2014 13:41:10 +0200, a écrit : > > > Start the translator specified by the NODE's passive translator record > > > and set it as NODE's active

Re: [PATCH 4/4] utils/settrans: implement settrans --start

2014-06-14 Thread Justus Winter
Quoting Samuel Thibault (2014-06-14 21:48:09) > Hello, > > Justus Winter, le Wed 11 Jun 2014 13:41:10 +0200, a écrit : > > Start the translator specified by the NODE's passive translator record > > and set it as NODE's active translator. This is the equivalent of > > doing: > > > > % settrans --

Re: [PATCH] utils/mount: canonicalize mountpoints

2014-06-14 Thread Samuel Thibault
Gabriele Giacone, le Thu 05 Jun 2014 00:34:45 +0200, a écrit : > * utils/mount.c (main): realpath mountpoint. > * utils/umount.c (do_umount): Likewise. Mmm, but sutils/fstab.c already does apply realpath, doesn't it? I see it doing it in fstab_find. What would this be needed for? Don't explain

Re: [PATCH 3/4] libdiskfs: add permission check to file_chflags

2014-06-14 Thread Samuel Thibault
Hello, Justus Winter, le Wed 11 Jun 2014 13:41:09 +0200, a écrit : > @@ -25,6 +25,12 @@ diskfs_S_file_chflags (struct protid *cred, > { >CHANGE_NODE_FIELD (cred, > ({ > + if (flags & 0x > + && ! idvec_contains (cred->user->u

Re: [PATCH 4/4] utils/settrans: implement settrans --start

2014-06-14 Thread Samuel Thibault
Hello, Justus Winter, le Wed 11 Jun 2014 13:41:10 +0200, a écrit : > Start the translator specified by the NODE's passive translator record > and set it as NODE's active translator. This is the equivalent of > doing: > > % settrans --active /node $(showtrans /node) A way to do it would be to ju